Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
james-prysm
reviewed
Mar 2, 2026
| ExecutionPayloadTopic = "execution_payload_available" | ||
| // ExecutionPayloadBidTopic represents a new execution payload bid event topic. | ||
| // This topic is currently not triggered but is recognized to avoid client subscription errors. | ||
| ExecutionPayloadBidTopic = "execution_payload_bid" |
Contributor
There was a problem hiding this comment.
we need some tests for this events.go file
Contributor
There was a problem hiding this comment.
we don'tneed payload_attestation_message for dora to be happy?
Contributor
Author
There was a problem hiding this comment.
not for now, payloads and the payload event are enough to show the green/yellow status of payloads.
james-prysm
reviewed
Mar 2, 2026
| if !ok { | ||
| return errors.New("expected `totalDifficulty` field in JSON response") | ||
| } | ||
| e.TotalDifficulty, _ = decoded["totalDifficulty"].(string) |
Contributor
There was a problem hiding this comment.
why doesn't this need to be handled? i think this change is unrelated
Contributor
Author
There was a problem hiding this comment.
This is no longer there in newer blocks it seems, proably something from v5? I honestly do not know but without this it panics on devnet0, so I made it optional
james-prysm
reviewed
Mar 2, 2026
|
|
||
| // ReconstructExecutionPayloadEnvelope -- | ||
| func (e *EngineClient) ReconstructExecutionPayloadEnvelope( | ||
| _ context.Context, envelope *ethpb.SignedBlindedExecutionPayloadEnvelope, |
Contributor
There was a problem hiding this comment.
do we need context if it's not used?
Contributor
Author
There was a problem hiding this comment.
This is in the mock, the original function uses it.
Contributor
There was a problem hiding this comment.
thanks just noticed that didn't realize in initial review
james-prysm
reviewed
Mar 2, 2026
| httputil.HandleError(w, "block_root is required in URL params", http.StatusBadRequest) | ||
| return | ||
| } | ||
| rootBytes, err := hexutil.Decode(blockRoot) |
Contributor
There was a problem hiding this comment.
this could use this helper instead of having the 2 checks
root, err := bytesutil.DecodeHexWithLength(req.BlockRoot, 32)
if err != nil {
httputil.HandleError(w, "Could not decode block root: "+err.Error(), http.StatusBadRequest)
return
}
terencechain
approved these changes
Mar 3, 2026
james-prysm
approved these changes
Mar 3, 2026
james-prysm
approved these changes
Mar 3, 2026
james-prysm
approved these changes
Mar 3, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
4 tasks
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
…h/v1/beacon/execution_payload_envelope/{block_id} defined in beacon apis (#16521)
**What type of PR is this?**
Bug fix
**What does this PR do? Why is it needed?**
missed this in review
we should have /eth/v1/beacon/execution_payload_envelope/{block_root} as
/eth/v1/beacon/execution_payload_envelope/{block_id} defined in beacon
apis
https://github.com/ethereum/beacon-APIs/blob/master/apis/beacon/execution_payload/envelope_get.yaml
missed in #16441
**Which issues(s) does this PR fix?**
Fixes #
**Other notes for review**
**Acknowledgements**
- [x] I have read
[CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md).
- [x] I have included a uniquely named [changelog fragment
file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd).
- [x] I have added a description with sufficient context for reviewers
to understand this PR.
- [x] I have tested that my changes work as expected and I added a
testing plan to the PR description (if applicable).
syjn99
pushed a commit
to syjn99/prysm
that referenced
this pull request
Mar 27, 2026
…h/v1/beacon/execution_payload_envelope/{block_id} defined in beacon apis (OffchainLabs#16521)
**What type of PR is this?**
Bug fix
**What does this PR do? Why is it needed?**
missed this in review
we should have /eth/v1/beacon/execution_payload_envelope/{block_root} as
/eth/v1/beacon/execution_payload_envelope/{block_id} defined in beacon
apis
https://github.com/ethereum/beacon-APIs/blob/master/apis/beacon/execution_payload/envelope_get.yaml
missed in OffchainLabs#16441
**Which issues(s) does this PR fix?**
Fixes #
**Other notes for review**
**Acknowledgements**
- [x] I have read
[CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md).
- [x] I have included a uniquely named [changelog fragment
file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd).
- [x] I have added a description with sufficient context for reviewers
to understand this PR.
- [x] I have tested that my changes work as expected and I added a
testing plan to the PR description (if applicable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it also adds as a stub without a trigger the execution_payload_bid event stream.
These are the minimum necessary to get Dora happy on Kurtosis. Haven't reviewed this PR yet, so opening it as draft. Only check was in Kurtosis against Dora.