Open
Conversation
Contributor
Author
|
#16306 implements overlapping types, so depending on which one merges first the coverage may overlap |
james-prysm
commented
Feb 3, 2026
| }, | ||
| { | ||
| Type: statefeed.ExecutionPayloadAvailable, | ||
| Data: &statefeed.ExecutionPayloadAvailableData{ |
Contributor
Author
There was a problem hiding this comment.
the api pr says slot and blockroot is all that is needed, should we suggest any other fields?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
implements the events defined in https://github.com/ethereum/beacon-APIs/pull/552/files#diff-3cc6eaa800c1a4bd6adcd78f1722b466f7a24048a66e320c8f92872fbcd9eefb
NOTE: DOES NOT ADD THE TRIGGERS FOR THE EVENTS IN PR
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements