-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add missing fulu presets to beacon config #16170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c51a743
add missing fulu constants to beacon config
satushh 3b2752b
changelog
satushh 565a7de
add update timeout
satushh bb3df74
Merge branch 'develop' into fulu-bcn-cfg
satushh 10856fc
Merge branch 'develop' into fulu-bcn-cfg
satushh ae6b10d
Merge branch 'develop' into fulu-bcn-cfg
satushh bfb2041
add update_timeout back to placeholderFields
satushh f64b971
Merge branch 'develop' into fulu-bcn-cfg
satushh b9e3492
avoid duplication
satushh aa7bd27
add back pre-existing comments
satushh e5c1135
whitespace
satushh d4464f4
Merge remote-tracking branch 'origin/develop' into fulu-bcn-cfg
satushh ac6ddd6
lint
satushh f70ac02
remove updatetimeout as a field in BeaconChainConfig
satushh f665612
ethspecify
satushh 7aa76bf
update update_timeout
satushh 3ce5b5d
remove exceptions
satushh 56cd55c
Merge branch 'develop' into fulu-bcn-cfg
satushh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ### Added | ||
|
|
||
| - Added missing beacon config in fulu so that the presets don't go missing in /eth/v1/config/spec beacon api. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update the ethspecify locations? specref ymls
how you use it #15592 (comment)