Add missing fulu presets to beacon config by satushh · Pull Request #16170 · OffchainLabs/prysm

satushh · 2025-12-19T12:33:49Z

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Added some missing constants of fulu to beacon config so that beacon api returns expected values

Which issues(s) does this PR fix?

Fixes #16138

Other notes for review

Acknowledgements

I have read CONTRIBUTING.md.
I have included a uniquely named changelog fragment file.
I have added a description with sufficient context for reviewers to understand this PR.
I have tested that my changes work as expected and I added a testing plan to the PR description (if applicable).

Inspector-Butters · 2025-12-19T13:46:53Z

it would be nice to replace the usages of FIELD_ELEMENTS_PER_CELL and NUMBER_OF_COLUMNS that are defined in config/fieldparams/mainnet.go and then delete them.

Inspector-Butters · 2025-12-19T13:50:07Z

the PR doesn't address one of the fields mentioned in the issue (UPDATE_TIMEOUT)

satushh · 2026-01-05T15:42:40Z

it would be nice to replace the usages of FIELD_ELEMENTS_PER_CELL and NUMBER_OF_COLUMNS that are defined in config/fieldparams/mainnet.go and then delete them.

Those are compile time array bounds, so they need to be constants at compile time.

the PR doesn't address one of the fields mentioned in the issue (UPDATE_TIMEOUT)

Added in the latest commit.

james-prysm · 2026-01-15T14:12:16Z

beacon-chain/rpc/eth/config/handlers.go

 	}

+	// Add derived values that are computed from other config values.
+	data["UPDATE_TIMEOUT"] = strconv.FormatUint(


even if this is a computed value I think it should be added to the config itself like the other ones, you can just note that it's also this calculation but typically config values are just hard coded

for example

MAX_REQUEST_DATA_COLUMN_SIDECARS == MAX_REQUEST_BLOCKS_DENEB * NUMBER_OF_COLUMNS

but we have max request data column sidecars in the specs.

something feels off though.. I wonder if we need to add a unit test to make sure that this is equal it seems strange to add it if it's never used anywhere

james-prysm · 2026-01-15T14:41:31Z

config/params/config.go

+	FieldElementsPerExtBlob               uint64           `yaml:"FIELD_ELEMENTS_PER_EXT_BLOB" spec:"true"`                  // FieldElementsPerExtBlob is the number of field elements in an extended blob.
+	KzgCommitmentsInclusionProofDepth     uint64           `yaml:"KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH" spec:"true"`        // KzgCommitmentsInclusionProofDepth is the depth of the KZG commitments inclusion proof.
+	CellsPerExtBlob                       uint64           `yaml:"CELLS_PER_EXT_BLOB" spec:"true"`                           // CellsPerExtBlob is the number of cells in an extended blob.
+	NumberOfColumns                       uint64           `yaml:"NUMBER_OF_COLUMNS" spec:"true"`                            // NumberOfColumns is the number of data columns in the network.


I don't think we should return these configs for the sake of returning, we need to tie it into how they are actually used otherwise we're going to run into a bug down the road ( even though we set this we aren't using it or at least validating it)

so for Number of Columns it actually got removed in
#16073

we need to understand why and if adding it back in this way makes sense

james-prysm · 2026-01-15T14:49:34Z

https://github.com/offchainlabs/prysm/blob/2773bdef89ab460aea4353d4d98833a4eeaa4918/specrefs/presets.yml we need to update this as well afterwards

prestonvanloon · 2026-01-15T17:05:20Z

config/params/loader_test.go

-	"FIELD_ELEMENTS_PER_CELL",     // Configured as a constant in config/fieldparams/mainnet.go
-	"FIELD_ELEMENTS_PER_EXT_BLOB", // Configured in proto/ssz_proto_library.bzl
 	"GLOAS_FORK_EPOCH",
 	"GLOAS_FORK_VERSION",
 	"INCLUSION_LIST_SUBMISSION_DEADLINE",
 	"INCLUSION_LIST_SUBMISSION_DUE_BPS",
-	"KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH", // Configured in proto/ssz_proto_library.bzl
 	"MAX_BYTES_PER_INCLUSION_LIST",
 	"MAX_REQUEST_BLOB_SIDECARS_FULU",
 	"MAX_REQUEST_INCLUSION_LIST",
 	"MAX_REQUEST_PAYLOADS", // Compile time constant on BeaconBlockBody.ExecutionRequests
 	"MIN_BUILDER_WITHDRAWABILITY_DELAY",
-	"NUMBER_OF_COLUMNS", // Configured as a constant in config/fieldparams/mainnet.go


These changes were defined elsewhere in the application. You've added them again so now we have the same constants twice. This is a bug risk if we ever needed to update or change the value, it may not be updated in all places. Can we avoid having the constants twice?

james-prysm · 2026-01-21T16:43:49Z

config/params/config.go

 	BalancePerAdditionalCustodyGroup      uint64           `yaml:"BALANCE_PER_ADDITIONAL_CUSTODY_GROUP" spec:"true"`         // BalancePerAdditionalCustodyGroup is the balance increment corresponding to one additional group to custody.

+	// Light client preset values
+	UpdateTimeout uint64 `yaml:"UPDATE_TIMEOUT" spec:"true"` // UpdateTimeout is SLOTS_PER_EPOCH * EPOCHS_PER_SYNC_COMMITTEE_PERIOD


talked offline but we can move this where the others are, makes sense to me

james-prysm · 2026-01-21T16:45:20Z

beacon-chain/rpc/eth/config/handlers.go


+	// Add Fulu preset values. These are compile-time constants from fieldparams,
+	// not runtime configs, but are required by the /eth/v1/config/spec API.
+	data["NUMBER_OF_COLUMNS"] = convertValueForJSON(reflect.ValueOf(uint64(fieldparams.NumberOfColumns)), "NUMBER_OF_COLUMNS")


can you update the ethspecify locations? specref ymls

how you use it #15592 (comment)

**What type of PR is this?** Feature **What does this PR do? Why is it needed?** Added some missing constants of fulu to beacon config so that beacon api returns expected values **Which issues(s) does this PR fix?** Fixes #16138 **Other notes for review** **Acknowledgements** - [ ] I have read [CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md). - [ ] I have included a uniquely named [changelog fragment file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd). - [ ] I have added a description with sufficient context for reviewers to understand this PR. - [ ] I have tested that my changes work as expected and I added a testing plan to the PR description (if applicable).

satushh added 2 commits December 19, 2025 18:00

add missing fulu constants to beacon config

c51a743

changelog

3b2752b

satushh added 2 commits January 5, 2026 20:48

add update timeout

565a7de

Merge branch 'develop' into fulu-bcn-cfg

bb3df74

satushh marked this pull request as ready for review January 5, 2026 15:38

Merge branch 'develop' into fulu-bcn-cfg

10856fc

satushh added 3 commits January 14, 2026 21:37

Merge branch 'develop' into fulu-bcn-cfg

ae6b10d

add update_timeout back to placeholderFields

bfb2041

Merge branch 'develop' into fulu-bcn-cfg

f64b971

james-prysm reviewed Jan 15, 2026

View reviewed changes

prestonvanloon reviewed Jan 15, 2026

View reviewed changes

satushh added 5 commits January 20, 2026 13:57

avoid duplication

b9e3492

add back pre-existing comments

aa7bd27

whitespace

e5c1135

Merge remote-tracking branch 'origin/develop' into fulu-bcn-cfg

d4464f4

lint

ac6ddd6

james-prysm added api bug-fix labels Jan 21, 2026

james-prysm reviewed Jan 21, 2026

View reviewed changes

satushh added 5 commits January 22, 2026 19:51

remove updatetimeout as a field in BeaconChainConfig

f70ac02

ethspecify

f665612

update update_timeout

7aa76bf

remove exceptions

3ce5b5d

Merge branch 'develop' into fulu-bcn-cfg

56cd55c

james-prysm approved these changes Jan 23, 2026

View reviewed changes

satushh enabled auto-merge January 23, 2026 14:59

satushh added this pull request to the merge queue Jan 23, 2026

Merged via the queue into develop with commit 4ff15fa Jan 23, 2026
19 checks passed

satushh deleted the fulu-bcn-cfg branch January 23, 2026 15:27

Comments

Conversation

satushh commented Dec 19, 2025

Uh oh!

Inspector-Butters commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Inspector-Butters commented Dec 19, 2025

Uh oh!

satushh commented Jan 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

james-prysm commented Jan 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Inspector-Butters commented Dec 19, 2025 •

edited

Loading