Skip to content

Reject Blob Sidecar Incorrect Index #13094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prylabs-bulldozer merged 6 commits into from
Oct 25, 2023
Merged

Reject Blob Sidecar Incorrect Index #13094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9291b3d
Gossip reject invalid blob index
terencechain Oct 22, 2023
eb4d701
Merge branch 'develop' into reject-sidecar-index
terencechain Oct 24, 2023
b5d1c36
Merge branch 'develop' into reject-sidecar-index
terencechain Oct 24, 2023
228658a
Merge refs/heads/develop into reject-sidecar-index
prylabs-bulldozer[bot] Oct 24, 2023
9271eff
Merge refs/heads/develop into reject-sidecar-index
prylabs-bulldozer[bot] Oct 24, 2023
0868644
Merge refs/heads/develop into reject-sidecar-index
prylabs-bulldozer[bot] Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion beacon-chain/sync/validate_blob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/prysmaticlabs/prysm/v4/beacon-chain/core/signing"
"github.com/prysmaticlabs/prysm/v4/beacon-chain/core/transition"
"github.com/prysmaticlabs/prysm/v4/beacon-chain/state"
fieldparams "github.com/prysmaticlabs/prysm/v4/config/fieldparams"
"github.com/prysmaticlabs/prysm/v4/config/params"
"github.com/prysmaticlabs/prysm/v4/crypto/bls"
"github.com/prysmaticlabs/prysm/v4/crypto/rand"
Expand Down Expand Up @@ -61,10 +62,16 @@ func (s *Service) validateBlob(ctx context.Context, pid peer.ID, msg *pubsub.Mes
}
blob := sBlob.Message

// [REJECT] The sidecar's index is consistent with `MAX_BLOBS_PER_BLOCK` -- i.e. `sidecar.index < MAX_BLOBS_PER_BLOCK`
if blob.Index >= fieldparams.MaxBlobsPerBlock {
log.WithFields(blobFields(blob)).Debug("Sidecar index > MAX_BLOBS_PER_BLOCK")
return pubsub.ValidationReject, errors.New("incorrect blob sidecar index")
}

// [REJECT] The sidecar is for the correct subnet -- i.e. compute_subnet_for_blob_sidecar(sidecar.index) == subnet_id.
want := fmt.Sprintf("blob_sidecar_%d", computeSubnetForBlobSidecar(blob.Index))
if !strings.Contains(*msg.Topic, want) {
log.WithFields(blobFields(blob)).Debug("Sidecar blob does not match topic")
log.WithFields(blobFields(blob)).Debug("Sidecar index does not match topic")
return pubsub.ValidationReject, fmt.Errorf("wrong topic name: %s", *msg.Topic)
}

Expand Down
26 changes: 26 additions & 0 deletions beacon-chain/sync/validate_blob_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"github.com/prysmaticlabs/prysm/v4/beacon-chain/state/stategen"
mockSync "github.com/prysmaticlabs/prysm/v4/beacon-chain/sync/initial-sync/testing"
lruwrpr "github.com/prysmaticlabs/prysm/v4/cache/lru"
fieldparams "github.com/prysmaticlabs/prysm/v4/config/fieldparams"
"github.com/prysmaticlabs/prysm/v4/config/params"
"github.com/prysmaticlabs/prysm/v4/consensus-types/blocks"
"github.com/prysmaticlabs/prysm/v4/crypto/bls"
Expand Down Expand Up @@ -81,6 +82,31 @@ func TestValidateBlob_InvalidMessageType(t *testing.T) {
require.Equal(t, result, pubsub.ValidationReject)
}

func TestValidateBlob_InvalidIndex(t *testing.T) {
ctx := context.Background()
p := p2ptest.NewTestP2P(t)
chainService := &mock.ChainService{Genesis: time.Unix(time.Now().Unix()-int64(params.BeaconConfig().SecondsPerSlot), 0)}
s := &Service{cfg: &config{p2p: p, initialSync: &mockSync.Sync{}, clock: startup.NewClock(chainService.Genesis, chainService.ValidatorsRoot)}}

msg := util.NewBlobsidecar()
msg.Message.Index = fieldparams.MaxBlobsPerBlock
buf := new(bytes.Buffer)
_, err := p.Encoding().EncodeGossip(buf, msg)
require.NoError(t, err)

topic := p2p.GossipTypeMapping[reflect.TypeOf(msg)]
digest, err := s.currentForkDigest()
require.NoError(t, err)
topic = s.addDigestAndIndexToTopic(topic, digest, 1)
result, err := s.validateBlob(ctx, "", &pubsub.Message{
Message: &pb.Message{
Data: buf.Bytes(),
Topic: &topic,
}})
require.ErrorContains(t, "incorrect blob sidecar index", err)
require.Equal(t, result, pubsub.ValidationReject)
}

func TestValidateBlob_InvalidTopicIndex(t *testing.T) {
ctx := context.Background()
p := p2ptest.NewTestP2P(t)
Expand Down