Reject Blob Sidecar Incorrect Index #13094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Oct 23, 2023
Contributor
nisdas
left a comment
nisdas
left a comment
There was a problem hiding this comment.
Our implementation was not vulnerable to the original bug, due to the fact we deferred from the spec, specifically this line:
[REJECT] The sidecar is for the correct subnet -- i.e. compute_subnet_for_blob_sidecar(sidecar.index) == subnet_id.We do not use the spec helper here, we should do so as there can always be the case where blobs per block > num of subnets and we would fail
Collaborator
Author
addressed in #13102 |
nisdas
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13079
This PR adds a new gossip rule, implementing the changes proposed in Ethereum Consensus Specs PR #3525. The new rule
REJECTsidecars with an index greater than or equal toMAX_BLOBS_PER_BLOCK.