Skip to content

fix: validator returning the right # of blobs #12738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terencechain merged 1 commit into from
Aug 14, 2023
Merged

fix: validator returning the right # of blobs #12738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions validator/client/propose.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,16 +124,16 @@ func (v *validator) ProposeBlock(ctx context.Context, slot primitives.Slot, pubK
var genericSignedBlock *ethpb.GenericSignedBeaconBlock
if blk.Version() >= version.Deneb && !blk.IsBlinded() {
signedBlobs := make([]*ethpb.SignedBlobSidecar, len(b.GetDeneb().Blobs))
for _, blob := range b.GetDeneb().Blobs {
for i, blob := range b.GetDeneb().Blobs {
blobSig, err := v.signBlob(ctx, blob, pubKey)
if err != nil {
log.WithError(err).Error("Failed to sign blob")
return
}
signedBlobs = append(signedBlobs, &ethpb.SignedBlobSidecar{
signedBlobs[i] = &ethpb.SignedBlobSidecar{
Message: blob,
Signature: blobSig,
})
}
}
denebBlock, err := blk.PbDenebBlock()
if err != nil {
Expand Down
4 changes: 4 additions & 0 deletions validator/client/propose_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,13 +673,17 @@ func testProposeBlock(t *testing.T, graffiti []byte) {
).DoAndReturn(func(ctx context.Context, block *ethpb.GenericSignedBeaconBlock) (*ethpb.ProposeResponse, error) {
sentBlock, err = blocktest.NewSignedBeaconBlockFromGeneric(block)
assert.NoError(t, err, "Unexpected error unwrapping block")
if tt.version == version.Deneb {
require.Equal(t, 2, len(block.GetDeneb().Blobs))
}
return &ethpb.ProposeResponse{BlockRoot: make([]byte, 32)}, nil
})

validator.ProposeBlock(context.Background(), 1, pubKey)
g := sentBlock.Block().Body().Graffiti()
assert.Equal(t, string(validator.graffiti), string(g[:]))
require.LogsContain(t, hook, "Submitted new block")

})
}
}
Expand Down