Skip to content

fix: validator returning the right # of blobs#12738

Merged
terencechain merged 1 commit intodeneb-integrationfrom
fix-validator-return
Aug 14, 2023
Merged

fix: validator returning the right # of blobs#12738
terencechain merged 1 commit intodeneb-integrationfrom
fix-validator-return

Conversation

@terencechain
Copy link
Collaborator

@terencechain terencechain commented Aug 14, 2023

The signedBlobs slice in ProposeBlock is allocated. Instead of append, it should assign. Also added a regression test

@terencechain terencechain self-assigned this Aug 14, 2023
@terencechain terencechain requested a review from a team as a code owner August 14, 2023 19:56
@terencechain terencechain requested review from nisdas, potuz and rkapka and removed request for a team August 14, 2023 19:56
@terencechain terencechain merged commit 0e81971 into deneb-integration Aug 14, 2023
@terencechain terencechain deleted the fix-validator-return branch August 14, 2023 20:23
terencechain added a commit that referenced this pull request Aug 16, 2023
@terencechain
fix: validator returning the right # of blobs (#12738)
89acf26
kasey pushed a commit that referenced this pull request Aug 21, 2023
@terencechain @kasey
fix: validator returning the right # of blobs (#12738)
7155bd1
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
fix: validator returning the right # of blobs (#12738)
3e1716a
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
fix: validator returning the right # of blobs (#12738)
2b8f59a
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
fix: validator returning the right # of blobs (#12738)
dd0afb6
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
fix: validator returning the right # of blobs (#12738)
e125c87
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
fix: validator returning the right # of blobs (#12738)
952953c
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
fix: validator returning the right # of blobs (#12738)
8df8b1d
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
fix: validator returning the right # of blobs (#12738)
4d1eabe
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
fix: validator returning the right # of blobs (#12738)
54748c6
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
0d4b03f
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
b565699
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
17d3965
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
0ae4d58
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
4e4bddc
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
10a962d
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
d02f959
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
76595ac
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
caa1558
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
aab4d56
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
64fb16e
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
49cf0bd
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
d95ed2c
prestonvanloon pushed a commit that referenced this pull request Aug 31, 2023
@terencechain @prestonvanloon
fix: validator returning the right # of blobs (#12738)
f5d5a50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james-prysm james-prysm james-prysm approved these changes

@potuz potuz Awaiting requested review from potuz potuz was automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka was automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas was automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terencechain @james-prysm