Skip to content

feat: optional allowlist for addresses that can interact with the inbox#685

Merged
PlasmaPower merged 5 commits intomasterfrom
inbox-allowlist
Jun 14, 2022
Merged

feat: optional allowlist for addresses that can interact with the inbox#685
PlasmaPower merged 5 commits intomasterfrom
inbox-allowlist

Conversation

@fredlacs
Copy link
Contributor

@fredlacs fredlacs commented Jun 10, 2022

we could pack the allowed addresses into bytes32 as in #623 but I don't think its worth it here given its temporary

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #685 (d96467f) into master (ad9c525) will increase coverage by 13.53%.
The diff coverage is 20.00%.

❗ Current head d96467f differs from pull request most recent head 3ac39bb. Consider uploading reports for the commit 3ac39bb to get more accurate results

@@             Coverage Diff             @@
##           master     #685       +/-   ##
===========================================
+ Coverage   33.97%   47.51%   +13.53%     
===========================================
  Files          59      214      +155     
  Lines        2758    22357    +19599     
  Branches      493      496        +3     
===========================================
+ Hits          937    10622     +9685     
- Misses       1821    10346     +8525     
- Partials        0     1389     +1389     

Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower enabled auto-merge June 14, 2022 20:16
@PlasmaPower PlasmaPower merged commit 333de33 into master Jun 14, 2022
@PlasmaPower PlasmaPower deleted the inbox-allowlist branch June 14, 2022 21:30
tsahee pushed a commit that referenced this pull request Jul 29, 2025
Follow up to #681 , this PR adds support for virtual, Merkle inclusion proofs for the optimized implementation.

Co-authored-by: Pepper Lebeck-Jobe <pepper@offchainlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants