Use 4-byte selector for Internal Transactions#681
Merged
edfelten merged 4 commits intoautomatic-l1-gas-pricingfrom Jun 10, 2022
Merged
Use 4-byte selector for Internal Transactions#681edfelten merged 4 commits intoautomatic-l1-gas-pricingfrom
edfelten merged 4 commits intoautomatic-l1-gas-pricingfrom
Conversation
edfelten
requested changes
Jun 10, 2022
arbos/util/util.go
Outdated
|
|
||
| var AddressAliasOffset *big.Int | ||
| var InverseAddressAliasOffset *big.Int | ||
| var InternalTxStartBlockMethodID [4]byte |
Contributor
There was a problem hiding this comment.
How are these initialized?
Contributor
Author
There was a problem hiding this comment.
These are initialized when installing the ArbosActs precompile in precompiles.go
Contributor
Author
There was a problem hiding this comment.
Fixed, I mistakenly duplicated these
Merged
edfelten
approved these changes
Jun 10, 2022
Contributor
edfelten
left a comment
edfelten
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing.
tsahee
pushed a commit
that referenced
this pull request
Jul 29, 2025
Co-authored-by: Pepper Lebeck-Jobe <pepper@offchainlabs.com>
tsahee
pushed a commit
that referenced
this pull request
Jul 29, 2025
Follow up to #681 , this PR adds support for virtual, Merkle inclusion proofs for the optimized implementation. Co-authored-by: Pepper Lebeck-Jobe <pepper@offchainlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the 4-byte method selector now that we've decided
ArbitrumInternalTx's always have abi-encoded dataAssociated PRs