Skip to content

Remove old ArbOS versions and their behaviors#683

Merged
rachel-bousfield merged 6 commits intoredo-devnet-reinit-1from
rm-old-arbos
Jun 17, 2022
Merged

Remove old ArbOS versions and their behaviors#683
rachel-bousfield merged 6 commits intoredo-devnet-reinit-1from
rm-old-arbos

Conversation

@PlasmaPower
Copy link
Contributor

@cla-bot cla-bot bot added the cla-signed label Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #683 (bab3696) into redo-devnet-reinit-1 (4c888fe) will decrease coverage by 4.59%.
The diff coverage is 69.23%.

❗ Current head bab3696 differs from pull request most recent head ac2031e. Consider uploading reports for the commit ac2031e to get more accurate results

@@                   Coverage Diff                    @@
##           redo-devnet-reinit-1     #683      +/-   ##
========================================================
- Coverage                 51.95%   47.36%   -4.60%     
========================================================
  Files                       223      212      -11     
  Lines                     26381    22012    -4369     
  Branches                    497      497              
========================================================
- Hits                      13707    10425    -3282     
+ Misses                    11289    10211    -1078     
+ Partials                   1385     1376       -9     

Base automatically changed from remove-tips to redo-devnet-reinit-1 June 14, 2022 16:13
Copy link
Contributor

@rachel-bousfield rachel-bousfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done reviewing but wanted to go ahead and request some changes along with those on the geth side

Copy link
Contributor

@rachel-bousfield rachel-bousfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rachel-bousfield rachel-bousfield added the geth Involves changes to Go-Ethereum label Jun 17, 2022
@rachel-bousfield rachel-bousfield merged commit 101c211 into redo-devnet-reinit-1 Jun 17, 2022
@rachel-bousfield rachel-bousfield deleted the rm-old-arbos branch June 17, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ArbOS cla-signed consensus geth Involves changes to Go-Ethereum

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants