Remove old ArbOS versions and their behaviors#683
Merged
rachel-bousfield merged 6 commits intoredo-devnet-reinit-1from Jun 17, 2022
Merged
Remove old ArbOS versions and their behaviors#683rachel-bousfield merged 6 commits intoredo-devnet-reinit-1from
rachel-bousfield merged 6 commits intoredo-devnet-reinit-1from
Conversation
Codecov Report
@@ Coverage Diff @@
## redo-devnet-reinit-1 #683 +/- ##
========================================================
- Coverage 51.95% 47.36% -4.60%
========================================================
Files 223 212 -11
Lines 26381 22012 -4369
Branches 497 497
========================================================
- Hits 13707 10425 -3282
+ Misses 11289 10211 -1078
+ Partials 1385 1376 -9 |
rachel-bousfield
suggested changes
Jun 17, 2022
Contributor
rachel-bousfield
left a comment
There was a problem hiding this comment.
Almost done reviewing but wanted to go ahead and request some changes along with those on the geth side
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points into #678
90% of this PR is removing the old L2 pricing model
Pulls in: