Fix fee history with exponential pricing and set ArbOS versions back to 1#108
Merged
rachel-bousfield merged 5 commits intomasterfrom Jun 17, 2022
Merged
Fix fee history with exponential pricing and set ArbOS versions back to 1#108rachel-bousfield merged 5 commits intomasterfrom
rachel-bousfield merged 5 commits intomasterfrom
Conversation
rachel-bousfield
suggested changes
Jun 17, 2022
Contributor
rachel-bousfield
left a comment
rachel-bousfield
left a comment
There was a problem hiding this comment.
The consensus changes look great, but there's some minor changes needed for the RPC
arbitrum/apibackend.go
Outdated
|
|
||
| // In vanilla geth, this RPC returns the gasUsed ratio so a client can infer how the basefee will change | ||
| // To emulate this, we translate the compute rate into something like that, centered at an analogous 0.5 | ||
| fullnessAnalogue := float64(blockGasUsed) / float64(speedLimit) / float64(timeSinceLastBlock) / 2.0 |
Contributor
There was a problem hiding this comment.
timeSinceLastBlock could be 0
Contributor
Author
There was a problem hiding this comment.
I've attempted to resolve this by keeping a running total of the current timestamp, instead of the current block. It's not perfect but I think it's a good method.
Tristan-Wilson
pushed a commit
that referenced
this pull request
May 22, 2023
Fix verification of blob txs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.