Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-2798] Test Stylus gas usage #2708

Merged
merged 14 commits into from
Oct 4, 2024
Merged

Conversation

gligneul
Copy link
Contributor

@gligneul gligneul commented Sep 27, 2024

These tests compare the gas usage of EVM opcodes and Stylus HostIOs.

This PR depends on the following contracts PR: OffchainLabs/nitro-contracts#255

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 27, 2024
@gligneul gligneul force-pushed the gligneul/program-gas-tests branch 2 times, most recently from 238015a to f0a9350 Compare September 27, 2024 15:03
These tests compare the gas usage of EVM opcodes and Stylus HostIOs.

Co-authored-by: Aman Sanghi <[email protected]>
Co-authored-by: Tsahi Zidenberg <[email protected]>
@gligneul gligneul marked this pull request as ready for review September 30, 2024 16:08
eljobe
eljobe previously approved these changes Oct 1, 2024
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Well structured and thorough. A few comments. The ones about maxdiff formulae is more important.

system_tests/program_gas_test.go Outdated Show resolved Hide resolved
system_tests/program_gas_test.go Outdated Show resolved Hide resolved
system_tests/program_gas_test.go Outdated Show resolved Hide resolved
system_tests/program_gas_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee enabled auto-merge October 4, 2024 01:26
@PlasmaPower PlasmaPower merged commit 956c5d9 into master Oct 4, 2024
16 checks passed
@PlasmaPower PlasmaPower deleted the gligneul/program-gas-tests branch October 4, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants