[NIT-2798] Add contracts for HostIO gas tests #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These contracts will be used by the nitro tests that check the equivalence between stylus and EVM. Co-authored-by: Aman Sanghi <[email protected]>
gligneul
changed the title
gzeoneth
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
LGTM
This PR does make the foundry config misalign with the hardhat config, I think it is ok since we are only using the hardhat build for production and it seems unlikely the different solc version and evm target would causes discrepancy in our tests. Might put up another PR in the near future to pin the pragma solidity of all contracts tho.
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These contracts will be used by the nitro tests that check the equivalence between stylus and EVM.
Related Nitro PR: OffchainLabs/nitro#2708