Skip to content

fix: surface eth deposits in migration package #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fredlacs wants to merge 3 commits into from
Closed

fix: surface eth deposits in migration package #87

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a44ffc0
add eth deposits to migration L1 to L2 message
fredlacs Jun 16, 2022
02a19e2
Revert "add eth deposits to migration L1 to L2 message"
fredlacs Jun 17, 2022
ef11031
add get all deposits function
fredlacs Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/lib/message/L1Transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,14 @@ export class L1TransactionReceipt implements TransactionReceipt {
this.nitroReceipt = new nitro.L1TransactionReceipt(tx)
}

public async getAllDeposits<T extends SignerOrProvider>(l2SignerOrProvider: T) {
Copy link
Contributor

@yahgwai yahgwai Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we should add a getAllDeposits func, instead we should a getEthDepositMessages func like we have in nitro, then use the toNitroEthDepositMessage function to convert the underlying messages into a nitro format

if (await isNitroL2(l2SignerOrProvider)) {
return this.nitroReceipt.getAllDeposits(l2SignerOrProvider)
} else {
return this.classicReceipt.getL1ToL2Messages(l2SignerOrProvider)
}
}

/**
* Get any l1tol2 messages created by this transaction
* @param l2SignerOrProvider
Expand Down