fix: surface eth deposits in migration package#87
Closed
fredlacs wants to merge 3 commits intoc-nitro-migrationfrom
Closed
fix: surface eth deposits in migration package#87fredlacs wants to merge 3 commits intoc-nitro-migrationfrom
fredlacs wants to merge 3 commits intoc-nitro-migrationfrom
Conversation
yahgwai
reviewed
Jun 20, 2022
| this.nitroReceipt = new nitro.L1TransactionReceipt(tx) | ||
| } | ||
|
|
||
| public async getAllDeposits<T extends SignerOrProvider>(l2SignerOrProvider: T) { |
Contributor
There was a problem hiding this comment.
I dont think we should add a getAllDeposits func, instead we should a getEthDepositMessages func like we have in nitro, then use the toNitroEthDepositMessage function to convert the underlying messages into a nitro format
fredlacs
changed the title
Contributor
Author
|
closed in favour of #88 |
umershaikh123
pushed a commit
to umershaikh123/arbitrum-sdk
that referenced
this pull request
May 20, 2024
…checker chore: L1 confirmation checker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using sdk v1 users would get the eth deposit message when interacting with the migration sdk
With the nitro sdk v3, you need a separate function call to get eth deposits.
We should bump up the nitro package to include #86 so the
statusfunction is also availableWe could attempt to make
EthDepositMessagecloser to aIL1ToL2MessageReaderOrWriterbut most methods would throw errors since they don't make sense.Instead making a separate entrypoint function
getAllDeposits, need to publish new nitro beta version to consume this here though