[octovis] Update dependencies to Qt5#286
Merged
ahornung merged 2 commits intoOctoMap:develfrom Mar 23, 2020
Merged
Conversation
Recently, OCTOVIS_QT5 was set to ON by default. This requires updated package dependencies to work on the buildfarm.
ahornung
reviewed
Mar 16, 2020
New keys introduced upstream in ros/rosdistro#24097
Member
Author
|
The rosdep keys are now available (cf. https://github.com/ros/rosdistro/pull/24097#event-3153219941) - i.e., we can go ahead in merging this PR and then creating a new patch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, OCTOVIS_QT5 was set to ON by default (cf. #280). This requires updated package dependencies to work on the buildfarm. I am unclear if this will fully work or if we first need to upstream
libqglviewer-qt5as a rosdep key, and then also add it tooctovis. With a localindustrial_cibuild, this appeared to work though.