Merged
Conversation
Thanks to kazuki0824 and anasarrak.
Copied from root CMakeFiles.txt to make this flag default ON even if building octovis as a module.
Member
|
Thanks! |
Member
|
This PR broke the ROS builds as the rosdep keys weren't updated in the package.xml. It turns out libqglviewer-qt5 isn't a rosdep key yet, so first needs to be upstreamed to rosdistro. |
This was referenced Mar 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
PR #238 seems to be stuck, so this one has the same CMake changes but does not touch ROS files while enabling Travis to build with Qt5.