forked from OSOceanAcoustics/echopype
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add attenuation mask #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Raluca Simedroni <[email protected]>
Co-authored-by: Raluca Simedroni <[email protected]>
Co-authored-by: Raluca Simedroni <[email protected]>
Co-authored-by: Raluca Simedroni <[email protected]>
Co-authored-by: Raluca Simedroni <[email protected]>
Co-authored-by: Raluca Simedroni <[email protected]>
Co-authored-by: Raluca Simedroni <[email protected]>
ruxandra-valcu
requested review from
beatfactor,
mihaiboldeanu and
simedroniraluca
September 13, 2023 14:31
Co-authored-by: Raluca Simedroni <[email protected]> Update mask_transformation.py Cleaned up mask_transformation Delinted Removing pytest req Refactoring Refactoring and cleaning imports Fixed twod test Fixing some future merge conflicts Fix unused import Added attenuation mask to init
ruxandra-valcu
force-pushed
the
feature/add-attenuation-mask
branch
from
September 13, 2023 17:50
380112e
to
9b0f7f7
Compare
2 tasks
mihaiboldeanu
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. Functionality correctly moved to clean from mask. Tests work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the attenuation mask functionality to the in-house dev branch