Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add attenuation mask #43

Merged
merged 17 commits into from
Sep 14, 2023
Merged

Conversation

ruxandra-valcu
Copy link
Collaborator

Adding the attenuation mask functionality to the in-house dev branch

Co-authored-by: Raluca Simedroni <[email protected]>

Update mask_transformation.py

Cleaned up mask_transformation

Delinted

Removing pytest req

Refactoring

Refactoring and cleaning imports

Fixed twod test

Fixing some future merge conflicts

Fix unused import

Added attenuation mask to init
@ruxandra-valcu ruxandra-valcu linked an issue Sep 14, 2023 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@mihaiboldeanu mihaiboldeanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Functionality correctly moved to clean from mask. Tests work.

@ruxandra-valcu ruxandra-valcu merged commit 465c61e into next Sep 14, 2023
11 checks passed
@ruxandra-valcu ruxandra-valcu deleted the feature/add-attenuation-mask branch November 3, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify signal attenuation code to work on any channel
3 participants