Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify signal attenuation code to work on any channel #45

Closed
2 tasks done
ruxandra-valcu opened this issue Sep 14, 2023 · 1 comment · Fixed by #43
Closed
2 tasks done

Modify signal attenuation code to work on any channel #45

ruxandra-valcu opened this issue Sep 14, 2023 · 1 comment · Fixed by #43
Assignees
@mihaiboldeanu
Labels
echopype

Comments

@ruxandra-valcu
Copy link
Collaborator

ruxandra-valcu commented Sep 14, 2023 •
edited by mihaiboldeanu
Loading

Currently, the mask is generated based on the first channel in the dataset (as it used to be in the echopy examples, which mostly worked on single-frequency data). We would want it to work on any channel we specify

Acceptance criteria:

  • Mask can be generated on a specified channel.

Tasks

  • Adapt the mask generation function to run on a specified channel
  • Adapt the tests so they work with the new function
@ruxandra-valcu ruxandra-valcu linked a pull request Sep 14, 2023 that will close this issue
Feature/add attenuation mask #43
Merged
@mihaiboldeanu
Copy link
Collaborator

added the fix in last commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihaiboldeanu mihaiboldeanu

Labels
echopype
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/add attenuation mask OceanStreamIO/echopype
2 participants
@ruxandra-valcu @mihaiboldeanu