Fix stale latest date displayed in Project Health Dashboard metrics

[anurag2787]

Proposed change

This PR fixes an issue where the Project Health Metrics dashboard was displaying outdated data

Resolves #3795

Checklist

• Required: I followed the contributing workflow
• Required: I verified that my code works as intended and resolves the issue as described
• Required: I ran make check-test locally: all warnings addressed, tests passed
• I used AI for code, documentation, tests, or communication related to this PR

[coderabbitai]

Summary by CodeRabbit

• Bug Fixes
  • Corrected the display order of health metrics charts to show data chronologically from oldest to newest, improving clarity when tracking project health over time.

Walkthrough

Backend query now returns the most-recent-first health metrics (descending by nest_created_at); frontend components reverse that list in-memory so charts and detail views iterate chronologically (oldest → newest) when rendering.

Changes

Cohort / File(s)	Summary
Backend: Project node backend/apps/owasp/api/internal/nodes/project.py	Changed health_metrics_list to select metrics ordered by -nest_created_at (most recent first); health_metrics_latest still returns the single most recent metric.
Frontend: Project metrics page frontend/src/app/projects/dashboard/metrics/[projectKey]/page.tsx	Sets healthMetricsList to a reversed copy of the incoming list so downstream code receives chronological (oldest→newest) ordering.
Frontend: Health metrics component frontend/src/components/HealthMetrics.tsx	Reverses the metrics array to chronological order and updates all derived chart series, labels, and index-based accesses to use the reversed array for chart rendering and calculations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Implement charts for health metrics #1633 — modifies backend ordering and frontend consumption of project health metrics (very similar data-flow changes).
• Add bar with markers instead of gradient radial chart #1703 — updates HealthMetrics.tsx data preparation and chart rendering (overlaps on frontend metric ordering).
• Implement the presentation of dashboard metrics list with filters #1718 — touches project health metrics endpoints and frontend usage (related changes to metrics list handling).

Suggested reviewers

• kasya

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change—fixing stale/outdated latest dates in the Project Health Dashboard metrics display.
Description check	✅ Passed	The description is related to the changeset, mentioning the issue being fixed (#3795) and the problem with outdated data display.
Linked Issues check	✅ Passed	The PR successfully addresses issue #3795 by fixing the data ordering to display the most recent metrics in chronological order across backend and frontend components.
Out of Scope Changes check	✅ Passed	All changes are scoped to fixing the stale data display issue—backend metric ordering and frontend chart rendering reflect the same objective.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

backend/apps/owasp/api/internal/nodes/project.py (1)

52-60: ⚠️ Potential issue | 🔴 Critical

Fix descending sort by reversing the slice to restore chronological order for trend analysis.

The change to descending order fixes which records are fetched (getting the newest instead of oldest), but now data[length - 1] in the frontend's HealthMetrics component points to the oldest metric, causing the "Days Since Last Commit/Release" chart to display stale values. Additionally, trend charts render in reverse chronological order.

Per documented learnings, health_metrics_list intentionally uses ascending order for chronological trend display, differing from health_metrics_latest which uses descending. Restore this pattern by reversing the slice:

Proposed fix

-        return root.health_metrics.order_by("-nest_created_at")[:normalized_limit]
+        return list(
+            root.health_metrics.order_by("-nest_created_at")[:normalized_limit]
+        )[::-1]

[anurag2787]

Hi @kasya the pr is ready for review please review it and let me know if any changes are required.

[arkid15r]

This fix looks too depressing, please revert. All my efforts make our metrics just going down 🥹

[arkid15r]

Seriously -- you're getting closer, but the timeline looks reversed.

[anurag2787]

This fix looks too depressing, please revert. All my efforts make our metrics just going down 🥹

Sorry for that 😅

[anurag2787]

@arkid15r I am little confused whether the ordering fix should be handled in the frontend or the backend but for now i have applied the reversal in the frontend. If you’d prefer this to be implemented in the backend instead i will update accordingly
Thanks

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@backend/apps/owasp/api/internal/nodes/project.py`:
- Line 64: The current return uses reversed() on a sliced QuerySet which raises
TypeError; materialize the queryset slice to a list first and then reverse it.
Replace the expression using
reversed(root.health_metrics.order_by("-nest_created_at")[:normalized_limit])
with a two-step approach: evaluate the queryset slice into a Python list (e.g.,
via list(...)) and then reverse that list (e.g., list_result[::-1] or
list(reversed(list_result))). Update the return in project.py (the function
returning the health metrics) to use the materialized list reversal.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[arkid15r]

@arkid15r I am little confused whether the ordering fix should be handled in the frontend or the backend but for now i have applied the reversal in the frontend. If you’d prefer this to be implemented in the backend instead i will update accordingly Thanks

When you have 2 solutions that both fix an issue -- always pick the simplest one.

Thanks for the fix 👍

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.24%. Comparing base (1d0ed82) to head (8486a28).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
backend/apps/owasp/api/internal/nodes/project.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3842   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         463      463           
  Lines       14416    14416           
  Branches     1939     1939           
=======================================
  Hits        13009    13009           
  Misses        988      988           
  Partials      419      419           

Flag	Coverage Δ
backend	90.97% <0.00%> (ø)
frontend	88.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
backend/apps/owasp/api/internal/nodes/project.py	74.19% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0ed82...8486a28. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.