fixed aloglia cache_key

[Mr-Rahul-Paul]

Resolves #3815

Summary

• Fixed cache key collision in Algolia search, facetFilters was extracted and used in queries but missing from the cache key.
• Two searches with the same query but different filters returned identical cached results.

Proposed change

Include facetFilters in the Algolia cache key. Filters are sorted and joined with _ to match existing key style and consistency.

Checklist

• Required: I followed the contributing workflow
• Required: I verified that my code works as intended and resolves the issue as described
• Required: I ran make check-test locally: all warnings addressed, tests passed
• I used AI for code, documentation, tests, or communication related to this PR

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Recomputes the Algolia cache key to include a serialized filters_key when facet_filters is non-empty (using json.dumps(facet_filters, sort_keys=True)), and adds tests validating caching behavior across differing and identical facet_filters.

Changes

Cohort / File(s)	Summary
Algolia cache key update backend/apps/core/api/internal/algolia.py	When facet_filters is non-empty, compute filters_key = json.dumps(facet_filters, sort_keys=True) and append it to the existing cache_key so cache get/set include facet filters.
Tests for caching & facet filters backend/tests/apps/core/api/internal/algolia_test.py	Added imports for CACHE_TTL_IN_SECONDS, CACHE_PREFIX; introduced _build_request helper; added tests asserting different facet_filters produce different results and identical requests hit cache (single backend call).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fixed aloglia cache_key' directly addresses the main change in the PR, which is fixing the cache key collision by including facetFilters.
Description check	✅ Passed	The description clearly explains the cache key collision issue, the proposed solution, and references the linked issue #3815, directly matching the changeset.
Linked Issues check	✅ Passed	The PR fully addresses issue #3815 by including facetFilters in the cache key using json.dumps with sorted keys, resolving the cache collision issue described in the linked issue.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the cache key collision issue: modifications to algolia.py implement the fix, and test additions validate the new behavior.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

1 issue found across 1 file

Confidence score: 3/5

• There is a concrete crash risk in backend/apps/core/api/internal/algolia.py when facetFilters includes nested arrays (valid Algolia OR syntax), which would raise a TypeError at runtime.
• Because this affects valid query shapes, there is some user-impacting regression risk despite being localized.
• Pay close attention to backend/apps/core/api/internal/algolia.py - handling of nested facetFilters arrays.

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="backend/apps/core/api/internal/algolia.py">

<violation number="1" location="backend/apps/core/api/internal/algolia.py:54">
P1: This will crash with `TypeError` if `facetFilters` contains nested arrays (valid Algolia OR syntax like `[["genre:comedy", "genre:drama"]]`). Consider using `json.dumps(facet_filters, sort_keys=True)` or flattening nested arrays before joining to handle all valid Algolia filter formats.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@backend/apps/core/api/internal/algolia.py`:
- Around line 54-58: The cache-key generation using
"_".join(sorted(facet_filters)) is collision-prone and will break on nested
lists; replace it by serializing facet_filters into a deterministic JSON string
and use that as filters_key (e.g., json.dumps(facet_filters, separators=(",",
":"), sort_keys=True)) so filters_key is collision-free and handles nested
structures; update where filters_key is referenced (the cache_key construction
that combines CACHE_PREFIX, index_name, query, page, limit, and filters_key) to
use this JSON-serialized value.

[arkid15r]

Please add/update tests.

[Mr-Rahul-Paul]

Hi ! @arkid15r do you want me to use json.dumps for filter keys as suggested by the bots ?

Thanks

[arkid15r]

Hi ! @arkid15r do you want me to use json.dumps for filter keys as suggested by the bots ? Thanks

The suggestion sounds reasonable.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@backend/tests/apps/core/api/internal/algolia_test.py`:
- Around line 252-253: Fix the inline comment and file ending: update the
comment before the assertion to include a space after the `#` and spaces around
the `=` (e.g., change `#backend only called once = caching worked` to `# backend
only called once = caching worked` or better `# backend only called once =
caching worked`), and ensure the test file ends with a trailing newline
character so Ruff W292 is satisfied; the assertion call to locate the spot is
`mock_get_search_results.assert_called_once()`.

🧹 Nitpick comments (1)

backend/tests/apps/core/api/internal/algolia_test.py (1)

31-45: Consider using _build_request in existing tests for consistency.

The helper is well-structured, but the existing test_algolia_search_valid_request (lines 70–81) and test_algolia_search_invalid_request (lines 163–173) still manually construct mock requests with the same structure. Consider refactoring them to use _build_request to reduce duplication.

[Mr-Rahul-Paul]

Added 2 tests to verify that different facet filters produce different results while identical requests return cached results.

[Mr-Rahul-Paul]

ready for review @arkid15r

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[arkid15r]

Please start running make check locally.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.38%. Comparing base (9c593c5) to head (8605180).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3825      +/-   ##
==========================================
+ Coverage   95.37%   95.38%   +0.01%     
==========================================
  Files         463      463              
  Lines       14541    14543       +2     
  Branches     2060     2017      -43     
==========================================
+ Hits        13868    13872       +4     
+ Misses        329      328       -1     
+ Partials      344      343       -1     

Flag	Coverage Δ
backend	95.67% <100.00%> (+0.01%)	⬆️
frontend	94.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
backend/apps/core/api/internal/algolia.py	84.00% <100.00%> (+4.83%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c593c5...8605180. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Mr-Rahul-Paul]

Noted , Thanks!