Skip to content

Comments

Remove unused 'placement' prop#2957

Merged
arkid15r merged 2 commits intoOWASP:mainfrom
mrkeshav-05:fix/card-test
Dec 19, 2025
Merged

Remove unused 'placement' prop#2957
arkid15r merged 2 commits intoOWASP:mainfrom
mrkeshav-05:fix/card-test

Conversation

@mrkeshav-05
Copy link
Contributor

Proposed change

This PR resolves the sonarcloud issue which is placement PropType is defined but prop is never used.

Resolves: #2889

Checklist

  • Required: I read and followed the contributing guidelines
  • Required: I ran make check-test locally and all tests passed
  • I used AI for code, documentation, or tests in this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Summary by CodeRabbit

Release Notes

  • Tests
    • Updated test mock configurations for improved test maintainability.

Note: This release contains no user-facing changes.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Removes the unused placement?: string property from the MockTooltipProps interface in the Card component test file. This is a direct response to issue #2889 identifying an undeclared but unused prop in the test mock type definition.

Changes

Cohort / File(s) Summary
Test mock type cleanup
frontend/__tests__/unit/components/Card.test.tsx
Removed unused optional property placement?: string from MockTooltipProps interface

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

frontend-tests

Suggested reviewers

  • arkid15r
  • kasya

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the unused 'placement' prop from the MockTooltipProps interface in Card.test.tsx.
Description check ✅ Passed The description clearly explains the change resolves a SonarCloud issue about an unused 'placement' PropType and links to issue #2889.
Linked Issues check ✅ Passed The PR successfully implements the requirement from issue #2889 by removing the unused 'placement' prop from MockToolTipProps interface in Card.test.tsx.
Out of Scope Changes check ✅ Passed All changes are in scope; only the unused 'placement' property was removed from the test file interface as required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a08db7 and b8fb6ce.

📒 Files selected for processing (1)
  • frontend/__tests__/unit/components/Card.test.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • frontend/tests/unit/components/Card.test.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arkid15r arkid15r enabled auto-merge December 18, 2025 23:38
@arkid15r arkid15r added this pull request to the merge queue Dec 18, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2025
@arkid15r arkid15r added this pull request to the merge queue Dec 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2025
@sonarqubecloud
Copy link

@arkid15r arkid15r added this pull request to the merge queue Dec 19, 2025
Merged via the queue into OWASP:main with commit f2d2bb5 Dec 19, 2025
26 checks passed
@mrkeshav-05 mrkeshav-05 deleted the fix/card-test branch December 19, 2025 09:29
Mr-Rahul-Paul pushed a commit to Mr-Rahul-Paul/Nest that referenced this pull request Jan 2, 2026
Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'placement' PropType is defined but prop is never used.

2 participants