Skip to content

Comments

Fix: Ensure tooltips appear on all cards instead of only the first one.#1054

Merged
arkid15r merged 2 commits intoOWASP:mainfrom
rishyym0927:bugFix/tooltip
Mar 8, 2025
Merged

Fix: Ensure tooltips appear on all cards instead of only the first one.#1054
arkid15r merged 2 commits intoOWASP:mainfrom
rishyym0927:bugFix/tooltip

Conversation

@rishyym0927
Copy link
Contributor

Resolves #997

The id of the tooltip should be unique to identity each of them seperately

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 8, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced tooltip functionality with unique identifiers that adapt based on card content, improving clarity and accessibility.
    • Updated tooltip positioning now consistently displays above the card for a better user experience.

Walkthrough

This change updates the Tooltip component within the Card component by modifying its id attribute. The static id value of "level-tooltip" is replaced with a dynamic template string id={level-tooltip-${title}}, allowing each instance of the Card component to have a unique tooltip ID based on its title prop. Additionally, a positioning prop is added to specify the tooltip's position. No modifications were made to any exported or public entities.

Changes

File(s) Change Summary
frontend/.../Card.tsx Modified the Tooltip component’s id attribute from a static value "level-tooltip" to a dynamic template string level-tooltip-${title}. Added a positioning prop with { placement: 'top' }. Removed redundant closeDelay line.

Suggested reviewers

  • kasya

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf23403 and e204310.

📒 Files selected for processing (1)
  • frontend/src/components/Card.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/src/components/Card.tsx
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: CodeQL (python)
  • GitHub Check: CodeQL (javascript-typescript)
  • GitHub Check: Run frontend e2e tests
  • GitHub Check: Run frontend unit tests
  • GitHub Check: Run backend tests

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@arkid15r arkid15r enabled auto-merge March 8, 2025 17:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2025

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Mar 8, 2025
Merged via the queue into OWASP:main with commit 1677c22 Mar 8, 2025
18 checks passed
@rishyym0927 rishyym0927 changed the title Fixed issue where tooltips were only appearing on the first card. Fix: Ensure tooltips appear on all cards instead of only the first one. Apr 3, 2025
shdwcodr pushed a commit to shdwcodr/Nest that referenced this pull request Jun 5, 2025
…ASP#1054)

* Fixed issue where tooltips were only appearing on the first card.

* Update code

---------

Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org>
@coderabbitai coderabbitai bot mentioned this pull request Dec 18, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix project level icon tooltip

2 participants