Skip to content

Feat/unlock map overlay #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swankystark wants to merge 2 commits into from
Closed

Feat/unlock map overlay #2928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad12904
feat: update map overlay to 'Unlock map' with unlock icon
swankystark Dec 10, 2025
0a2181e
feat: add hover effect to unlock map button and address review feedback
swankystark Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions frontend/__tests__/unit/components/ChapterMap.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,24 +266,24 @@ describe('ChapterMap', () => {
})

describe('Interactive Overlay', () => {
it('displays overlay with "Click to interact with map" message initially', () => {
it('displays overlay with "Unlock map" message initially', () => {
const { getByText } = render(<ChapterMap {...defaultProps} />)
expect(getByText('Click to interact with map')).toBeInTheDocument()
expect(getByText('Unlock map')).toBeInTheDocument()
})

it('removes overlay when clicked', () => {
const { getByText, queryByText } = render(<ChapterMap {...defaultProps} />)

const overlay = getByText('Click to interact with map').closest('button')
const overlay = getByText('Unlock map').closest('button')
fireEvent.click(overlay!)

expect(queryByText('Click to interact with map')).not.toBeInTheDocument()
expect(queryByText('Unlock map')).not.toBeInTheDocument()
})

it('enables scroll wheel zoom when overlay is clicked', () => {
const { getByText } = render(<ChapterMap {...defaultProps} />)

const overlay = getByText('Click to interact with map').closest('button')
const overlay = getByText('Unlock map').closest('button')
fireEvent.click(overlay!)

expect(mockMap.scrollWheelZoom.enable).toHaveBeenCalled()
Expand All @@ -292,7 +292,7 @@ describe('ChapterMap', () => {
it('handles keyboard interaction with Enter key', () => {
const { getByText } = render(<ChapterMap {...defaultProps} />)

const overlay = getByText('Click to interact with map').closest('button')
const overlay = getByText('Unlock map').closest('button')
fireEvent.keyDown(overlay!, { key: 'Enter' })

expect(mockMap.scrollWheelZoom.enable).toHaveBeenCalled()
Expand All @@ -301,7 +301,7 @@ describe('ChapterMap', () => {
it('handles keyboard interaction with Space key', () => {
const { getByText } = render(<ChapterMap {...defaultProps} />)

const overlay = getByText('Click to interact with map').closest('button')
const overlay = getByText('Unlock map').closest('button')
fireEvent.keyDown(overlay!, { key: ' ' })

expect(mockMap.scrollWheelZoom.enable).toHaveBeenCalled()
Expand All @@ -310,9 +310,9 @@ describe('ChapterMap', () => {
it('has proper accessibility attributes', () => {
const { getByText } = render(<ChapterMap {...defaultProps} />)

const overlay = getByText('Click to interact with map').closest('button')
const overlay = getByText('Unlock map').closest('button')
expect(overlay).toHaveAttribute('tabIndex', '0')
expect(overlay).toHaveAttribute('aria-label', 'Click to interact with map')
expect(overlay).toHaveAttribute('aria-label', 'Unlock map')
})
})

Expand Down
9 changes: 6 additions & 3 deletions frontend/src/components/ChapterMap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
'use client'
import { faLockOpen } from '@fortawesome/free-solid-svg-icons'
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
import L, { MarkerClusterGroup } from 'leaflet'
import React, { useEffect, useRef, useState } from 'react'
import type { Chapter } from 'types/chapter'
Expand Down Expand Up @@ -144,10 +146,11 @@ const ChapterMap = ({
setIsMapActive(true)
}
}}
aria-label="Click to interact with map"
aria-label="Unlock map"
>
<p className="rounded-md bg-white/90 px-5 py-3 text-sm font-medium text-gray-700 shadow-lg dark:bg-gray-700 dark:text-white">
Click to interact with map
<p className="flex items-center gap-2 rounded-md bg-white/90 px-5 py-3 text-sm font-medium text-gray-700 shadow-lg transition-all hover:scale-105 hover:bg-white dark:bg-gray-700 dark:text-white dark:hover:bg-gray-600">
<FontAwesomeIcon icon={faLockOpen} className="h-4 w-4" />
Unlock map
</p>
</button>
)}
Expand Down