Skip to content

Comments

Feat/unlock map overlay#2928

Closed
swankystark wants to merge 2 commits intoOWASP:mainfrom
swankystark:feat/unlock-map-overlay
Closed

Feat/unlock map overlay#2928
swankystark wants to merge 2 commits intoOWASP:mainfrom
swankystark:feat/unlock-map-overlay

Conversation

@swankystark
Copy link

Proposed change

This PR updates the map interaction overlay to specific "Unlock map" actions with visual improvements, addressing feedback from the previous PR.

Changes:

  • Changed overlay text from 'Click to interact with map' to 'Unlock map'.
  • Added unlock icon (faLockOpen) from FontAwesome before the text.
  • Added hover effect: Button now scales up (hover:scale-105) and brightens on hover for clearer interactivity.
  • Updated aria-label to "Unlock map" for better accessibility.
  • Updated all related unit tests in ChapterMap.test.tsx to match the new text.

Verification:

  • Validated visually on local development server.
  • Ran make check-test in WSL environment and all checks passed (including linting and unit tests).

Checklist

  • I read and followed the contributing guidelines
  • I ran make check-test locally and all tests passed
  • I used AI for code, documentation, or tests in this PR

- Changed overlay text from 'Click to interact with map' to 'Unlock map'
- Added unlock icon (faLockOpen) from FontAwesome before text
- Updated aria-label for better accessibility
- Updated all related unit tests

All tests passing (30/30)
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • Style
    • Map unlock button redesigned with integrated lock icon for improved visual communication and clarity.
    • Button text updated to "Unlock map" providing more intuitive guidance for user interaction.
    • Enhanced with smooth hover transitions and refined visual styling for better interactive feedback and user experience.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Updates the ChapterMap component overlay UI by changing label text from "Click to interact with map" to "Unlock map", adding a lock-open icon, and updating the aria-label. Corresponding test assertions are updated to reflect these new text values.

Changes

Cohort / File(s) Summary
ChapterMap Component
frontend/src/components/ChapterMap.tsx
Updated aria-label from "Click to interact with map" to "Unlock map". Imported FontAwesomeIcon and faLockOpen. Replaced overlay text with lock-open icon and "Unlock map" label; added hover effect styling/transition classes.
ChapterMap Tests
frontend/__tests__/unit/components/ChapterMap.test.tsx
Updated test descriptions, getByText lookups, button selectors, and aria-label assertions to reference new "Unlock map" text instead of "Click to interact with map".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Text and aria-label updates are straightforward replacements across both files
  • Icon addition is a standard FontAwesome usage pattern
  • Test changes follow consistent pattern of updating expected values

Possibly related PRs

Suggested labels

frontend, frontend-tests

Suggested reviewers

  • arkid15r
  • kasya
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ffb2c2 and 0a2181e.

📒 Files selected for processing (2)
  • frontend/__tests__/unit/components/ChapterMap.test.tsx (4 hunks)
  • frontend/src/components/ChapterMap.tsx (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

The PR must be linked to an issue assigned to the PR author.

@github-actions github-actions bot closed this Dec 15, 2025
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant