Skip to content

Fix regex for chapter leader #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkid15r merged 2 commits into from
Mar 15, 2025
Merged

Fix regex for chapter leader #1118

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4898ca8
fix-regex-for-chapter-leader
Naveen-Pal Mar 15, 2025
ecd1c2e
fixing dos in regex
Naveen-Pal Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/apps/owasp/models/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def get_leaders(self):
leaders = []
try:
for line in content.split("\n"):
leaders.extend(re.findall(r"[-*]\s*\[([^\]]+)\](?:\([^)]*\))?", line))
leaders.extend(re.findall(r"[-*]\s*\[\s*([^(]+?)\s*(?:\([^)]*\))?\]", line))
except AttributeError:
logger.exception(
"Unable to parse leaders.md content", extra={"URL": self.leaders_md_url}
Expand Down
6 changes: 3 additions & 3 deletions backend/tests/owasp/models/common_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ class TestRepositoryBasedEntityModel:
@pytest.mark.parametrize(
("content", "expected_leaders"),
[
("* [Leader1](https://example.com)", ["Leader1"]),
("- [Leader1](https://example.com)", ["Leader1"]),
(
"* [Leader1](https://example.com)\n* [Leader2](https://example.com)",
["Leader1", "Leader2"],
"* [Leader one (Chapter Lead)](https://example.com)\n* [Leader two (Faculty Advisor)](https://example.com)",
["Leader one", "Leader two"],
),
("", []),
],
Expand Down