Skip to content

Used Millify for main page counters#1083

Merged
arkid15r merged 3 commits intoOWASP:mainfrom
Riddhikshah21:feature/1025-millify-main-page-counters
Mar 12, 2025
Merged

Used Millify for main page counters#1083
arkid15r merged 3 commits intoOWASP:mainfrom
Riddhikshah21:feature/1025-millify-main-page-counters

Conversation

@Riddhikshah21
Copy link
Contributor

Resolves #1025

Used Millify to Make counters to be shortened, e.g. 11K+ for 11100+

Screenshot 2025-03-11 at 11 01 16 PM

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced number presentation in counters by converting larger values into a compact, more readable format (e.g., displaying 1000 as "1k").

Walkthrough

This pull request updates the AnimatedCounter component to improve number formatting. The changes include importing the millify function from the millify library and modifying the component's return statement to apply millify(count). This adjustment converts larger numerical values (e.g., 1000 to "1k"), enhancing the readability of the displayed count.

Changes

File Change Summary
frontend/.../AnimatedCounter.tsx Added import for millify and updated return statement to format count using millify(count)

Suggested labels

frontend

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
frontend/src/components/AnimatedCounter.tsx (1)

34-34: Implementation looks good!

The application of millify(count) properly formats the count for better readability. This successfully converts large numbers like 11100 to "11.1k" for improved user experience.

Consider if you need any customization options that millify provides, such as:

  • precision - to control decimal places
  • lowercase - for "k" instead of "K"
  • space - to add space between number and suffix

Example with options: millify(count, { precision: 1, lowercase: true })

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6a44e6 and c74fd6b.

⛔ Files ignored due to path filters (1)
  • frontend/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • frontend/src/components/AnimatedCounter.tsx (2 hunks)
🔇 Additional comments (1)
frontend/src/components/AnimatedCounter.tsx (1)

2-2: Good addition of millify library

The millify library is a good choice for formatting large numbers into human-readable format. This aligns well with the PR objective to improve counter display.

@sonarqubecloud
Copy link

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for updating this

@arkid15r arkid15r enabled auto-merge March 12, 2025 16:16
@arkid15r arkid15r added this pull request to the merge queue Mar 12, 2025
Merged via the queue into OWASP:main with commit ab0051a Mar 12, 2025
15 of 16 checks passed
shdwcodr pushed a commit to shdwcodr/Nest that referenced this pull request Jun 5, 2025
* Used Millify for main page counters

* Update code

---------

Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org>
@coderabbitai coderabbitai bot mentioned this pull request Aug 3, 2025
2 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 15, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Millify main page counters

2 participants