fixed issue #965 Corrected Link Redirection of recent issues, updated tests and UI change.#1001
Conversation
Summary by CodeRabbit
WalkthroughThis pull request updates several test cases and UI components. In multiple end-to-end and unit tests, assertions checking for the presence of specific author or contributor names in recent issues and releases have been removed. The GraphQL query for project data is enhanced by adding a new Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/src/components/CardDetailsPage.tsx (1)
99-104: Improved UI rendering with conditional comments display.This enhancement properly implements optional chaining to conditionally render the comments count only when it exists. This prevents displaying empty comment sections when there are no comments available.
While the implementation is good, consider enhancing it to handle zero comments explicitly:
- {item?.commentsCount ? ( + {item?.commentsCount > 0 ? (This way, it won't show "0 comments" which might be redundant information.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
frontend/__tests__/e2e/pages/Home.spec.ts(0 hunks)frontend/__tests__/e2e/pages/ProjectDetails.spec.ts(0 hunks)frontend/__tests__/e2e/pages/RepositoryDetails.spec.ts(0 hunks)frontend/__tests__/unit/pages/ProjectDetails.test.tsx(0 hunks)frontend/__tests__/unit/pages/RepositoryDetails.test.tsx(0 hunks)frontend/src/api/queries/projectQueries.ts(1 hunks)frontend/src/components/CardDetailsPage.tsx(1 hunks)frontend/src/components/ItemCardList.tsx(1 hunks)
💤 Files with no reviewable changes (5)
- frontend/tests/e2e/pages/Home.spec.ts
- frontend/tests/unit/pages/ProjectDetails.test.tsx
- frontend/tests/unit/pages/RepositoryDetails.test.tsx
- frontend/tests/e2e/pages/RepositoryDetails.spec.ts
- frontend/tests/e2e/pages/ProjectDetails.spec.ts
🔇 Additional comments (3)
frontend/src/api/queries/projectQueries.ts (2)
19-19: URL field added to recentIssues - good enhancement.Adding the
urlfield to recentIssues is a good improvement that enables direct linking to issues, which addresses part of the problem mentioned in issue #965 about buttons not functioning correctly.
24-24: URL field added to author object - good enhancement.Adding the
urlfield to the author object within recentIssues allows proper linking to user profiles, addressing the issue mentioned in #965 about buttons not linking to user profiles correctly.frontend/src/components/ItemCardList.tsx (1)
23-43:Details
✅ Verification successful
Fixed item card structure and links to address issue #965.
The improved structure of item cards now properly links to both GitHub issues and user profiles, addressing the core issue reported in #965. The layout changes also improve the design consistency.
Key improvements:
- The user avatar now correctly links to the user profile
- The issue/release title now properly links to its URL
- Better layout structure with proper width constraints
Let's verify that the user profile URL format follows the expected pattern:
🏁 Script executed:
#!/bin/bash # Check if there are other references to user profile URLs in the codebase # to ensure the new format is consistent echo "Checking for user profile URL patterns in the codebase..." rg -g "*.tsx" -g "*.ts" --no-filename "/community/users/" | grep -v "ItemCardList.tsx"Length of output: 868
Fixed Item Card Structure and URL Linking for Issue #965
The updated code now correctly links user avatars to their profiles using the consistent
/community/users/{user}format – a pattern that was verified against other instances in the codebase. Additionally, the issue/release title correctly links to its URL, and the layout adjustments improve the overall design consistency.Key improvements:
- The user avatar now correctly links to the user profile (verified with consistent pattern usage).
- The issue/release title now properly links to its associated URL.
- The layout has been refined with better width constraints for improved readability.
KaranNegi20Feb
changed the title
KaranNegi20Feb
changed the title
|
arkid15r
left a comment
arkid15r
left a comment
There was a problem hiding this comment.
LGTM 👍
It looks better now, thank you!
…dated tests and UI change. (OWASP#1001) * Resolved merge conflicts and updated code * Update code --------- Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org>
2 participants
Fixes Issue
Issue: #965
Describe the bug
Buttons don't link to the github issue, user profile and design changes.
Result
Desktop view:
Mobile view:
