Issue resolved : #1068 Correction to overflow of name in usercard by KaranNegi20Feb · Pull Request #1070 · OWASP/Nest

KaranNegi20Feb · 2025-03-10T17:24:10Z

Resolves #1068 UI Improvement: The name overflows the div container.
Here's the corrected version of the usercard:

coderabbitai · 2025-03-10T17:24:18Z

Summary by CodeRabbit

New Features
- User cards now display additional details including email and location.
- The card’s information now shows company data, but if unavailable, it falls back to showing location or email.
Style
- Updated text display properties for headings to enforce a maximum width and truncation for improved readability.

Walkthrough

The pull request updates the UserCard component by adding email and location properties to its function signature. The content of the paragraph element now displays the company name, or if that is not available, it falls back to displaying the email or location. Additionally, the class name for the <h3> element has been changed to allow for a maximum width of 250 pixels with text truncation. The Users page has also been updated to pass the new properties to the UserCard.

Changes

File	Change Summary
`frontend/src/components/UserCard.tsx`	Added `email` and `location` to `UserCardProps`, modified paragraph content to display `company` or `email` or `location`, and changed `<h3>` class from `line-clamp-1` to `max-w-[250px] truncate`.
`frontend/src/pages/Users.tsx`	Added `email` and `location` properties to the `UserCard` component in the `renderUserCard` function, populated from the `user` object.
`frontend/src/types/card.ts`	Added `email: string` and `location: string` properties to the `UserCardProps` interface.

Suggested labels

frontend-tests

Suggested reviewers

kasya

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd5a3db and b2a7f83.

📒 Files selected for processing (3)

frontend/src/components/UserCard.tsx (2 hunks)
frontend/src/pages/Users.tsx (1 hunks)
frontend/src/types/card.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

frontend/src/types/card.ts
frontend/src/pages/Users.tsx
frontend/src/components/UserCard.tsx

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: CodeQL (python)
GitHub Check: CodeQL (javascript-typescript)
GitHub Check: Run frontend e2e tests
GitHub Check: Run frontend unit tests
GitHub Check: Run backend tests

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

KaranNegi20Feb · 2025-03-10T17:34:07Z

Hey @arkid15r i have made the required changes please go through those, Thank you 😊.

arkid15r

Looks good, could you improve it a bit?

frontend/src/components/UserCard.tsx

KaranNegi20Feb · 2025-03-10T18:09:04Z

Hey @arkid15r thanks for the suggestions, Now the PR is ready for review, please go through the changes, Thank you😊.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

frontend/src/types/card.ts (1)
47-54: Interface expansion looks good, but consider optional properties

The addition of email and location properties to the UserCardProps interface aligns well with the PR objective to address the overflow issue. According to the AI summary, these properties are used as fallbacks when company information isn't available.

However, consider making these new properties optional with the ? operator since they might not always be available for every user, which would improve flexibility:
export interface UserCardProps {
  avatar: string
  button: ButtonType
  company: string
  name: string
- email: string
- location: string
+ email?: string
+ location?: string
}

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b113dd7 and dd5a3db.

📒 Files selected for processing (1)

frontend/src/types/card.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: CodeQL (python)
GitHub Check: CodeQL (javascript-typescript)
GitHub Check: Run backend tests
GitHub Check: Run frontend e2e tests
GitHub Check: Run frontend unit tests

sonarqubecloud · 2025-03-10T18:47:54Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

arkid15r

LGTM

OWASP#1070) * correction to overflow of name in usercard * review resolved * review resolved new * company or email or location added * company or email or location added and interface change * Update code --------- Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org>

correction to overflow of name in usercard

bcf1778

KaranNegi20Feb requested review from arkid15r and kasya as code owners March 10, 2025 17:24

github-actions bot added the frontend label Mar 10, 2025

arkid15r requested changes Mar 10, 2025

View reviewed changes

frontend/src/components/UserCard.tsx Outdated Show resolved Hide resolved

review resolved

7fb9226

KaranNegi20Feb requested a review from arkid15r March 10, 2025 18:08

KaranNegi20Feb added 2 commits March 10, 2025 23:45

review resolved new

05ceef5

company or email or location added

b113dd7

KaranNegi20Feb marked this pull request as draft March 10, 2025 18:29

company or email or location added and interface change

dd5a3db

coderabbitai bot reviewed Mar 10, 2025

View reviewed changes

KaranNegi20Feb marked this pull request as ready for review March 10, 2025 18:36

Update code

b2a7f83

arkid15r approved these changes Mar 10, 2025

View reviewed changes

arkid15r enabled auto-merge March 10, 2025 18:49

arkid15r added this pull request to the merge queue Mar 10, 2025

Merged via the queue into OWASP:main with commit a6644aa Mar 10, 2025
18 checks passed

This was referenced Mar 11, 2025

Fix issue: #963 UI Overflow on Mobile for Home page #1030

Merged

Smooth animation for expanding/collapsing repositories list #1069

Closed

Improve algolia.py input data validation #1046

Merged

coderabbitai bot mentioned this pull request Mar 11, 2025

Changed the logic of fetching leader's data #990

Merged

coderabbitai bot mentioned this pull request Mar 24, 2025

Truncated text component #1117

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue resolved : #1068 Correction to overflow of name in usercard #1070

Issue resolved : #1068 Correction to overflow of name in usercard #1070
arkid15r merged 6 commits intoOWASP:mainfrom
KaranNegi20Feb:username-fix

KaranNegi20Feb commented Mar 10, 2025

Uh oh!

coderabbitai bot commented Mar 10, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

KaranNegi20Feb commented Mar 10, 2025

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

KaranNegi20Feb commented Mar 10, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

sonarqubecloud bot commented Mar 10, 2025

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Uh oh!

Conversation

KaranNegi20Feb commented Mar 10, 2025

Uh oh!

coderabbitai bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

KaranNegi20Feb commented Mar 10, 2025

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

KaranNegi20Feb commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 10, 2025

Quality Gate passed

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

coderabbitai bot commented Mar 10, 2025 •

edited

Loading

KaranNegi20Feb commented Mar 10, 2025 •

edited

Loading