feat: add redis-role label to redis replication #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #925 +/- ##
==========================================
+ Coverage 35.20% 39.08% +3.88%
==========================================
Files 19 20 +1
Lines 3213 2720 -493
==========================================
- Hits 1131 1063 -68
+ Misses 2015 1586 -429
- Partials 67 71 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
mattrobinsonsre
pushed a commit
to mattrobinsonsre/redis-operator
that referenced
this pull request
Jul 11, 2024
* feat: add redis-role label to redis replication Signed-off-by: drivebyer <[email protected]> * fix lint Signed-off-by: drivebyer <[email protected]> * fix lint Signed-off-by: drivebyer <[email protected]> * fix test Signed-off-by: drivebyer <[email protected]> * fix test Signed-off-by: drivebyer <[email protected]> * fix test Signed-off-by: drivebyer <[email protected]> * fix test Signed-off-by: drivebyer <[email protected]> * fix test Signed-off-by: drivebyer <[email protected]> * fix test Signed-off-by: drivebyer <[email protected]> * fix test Signed-off-by: drivebyer <[email protected]> --------- Signed-off-by: drivebyer <[email protected]> Signed-off-by: Matt Robinson <[email protected]>
4 tasks
|
Hey, I just triggered a failover. I noticed that the master gets patched to slave but the slave does not get patched to master. Would this be something easy to fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #765
Type of change
Checklist
Additional Context