Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The name and label role of the pod after master-slave switching are incorrect #882

Closed
xiaozhuang-a opened this issue Apr 19, 2024 · 5 comments
Assignees
Labels
question Further information is requested

Comments

@xiaozhuang-a
Copy link
Contributor

Describe your question

What version of redis-operator are you using?

redis-operator version:

Additional context

@xiaozhuang-a xiaozhuang-a added the question Further information is requested label Apr 19, 2024
@drivebyer drivebyer self-assigned this Apr 19, 2024
@drivebyer
Copy link
Collaborator

It needs to be fixed.

@xiaozhuang-a
Copy link
Contributor Author

xiaozhuang-a commented Apr 19, 2024

It needs to be fixed.

Do you have any solutions
I understand. Can we solve this by not distinguishing between leaders and followers in STS ? or rather, what is the current pattern used to distinguish between leaders and followers

@drivebyer
Copy link
Collaborator

We can use the label key redis-role to distinguish between the master and slave, which is implemented by #925.

@drivebyer
Copy link
Collaborator

As said to the leader and follower words in the pod name, it's really hard to improve it because we need to use a different name to create a Redis cluster.

@xiaozhuang-a
Copy link
Contributor Author

It needs to be fixed.

Is there any issue follow-up for label updates in Redis cluster mode? I understand that a separate rotation mechanism is needed to regularly obtain Redis cluster status and update it to CR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants