Skeleton interface bindings #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort types will be changing soon).
…f arrays. This ensures that the skeleton interface does not introduce GC pressure when used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oddity you may notice in these bindings is the use of struct fields in place of the fixed sized OSVR_SkeletonJointReport arrays in the native code. Using struct fields eliminates the GC pressure from marshaling that array into a managed array (which has to be allocated and garbage collected).
However, this is a common pattern you see in many performance critical .net-native bindings. For example, XNA matrices are defined not with arrays but with public fields for each cell.
Don't merge until the OSVR-Core skeleton branch is merged:
https://github.com/OSVR/OSVR-Core/tree/skeleton