Drop artificially created ping_time dimension
#1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without ping_time dim
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## dev #1083 +/- ##
===========================================
- Coverage 78.15% 66.51% -11.64%
===========================================
Files 65 32 -33
Lines 6229 4056 -2173
===========================================
- Hits 4868 2698 -2170
+ Misses 1361 1358 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 50 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
emiliom
reviewed
Jul 23, 2023
emiliom
reviewed
Jul 24, 2023
|
Sound good. I think I've addressed your comments and will merge after the tests run through (though I did not make any code changes in the new commits). |
lsetiawan
pushed a commit
to lsetiawan/echopype
that referenced
this pull request
Jul 28, 2023
* remove artifically added ping_time dim from set_groups_* * remove check of ping_time in split_beam_angle.py::get_angle_complex_samples * add additional comments to test_cal_params_integration.py * add additional comments to calibrate_ek.py::_assimilate_ecs_cal_params * remove unused (already commented out) lines in ek80_complex.py::compress_pulse * update cal_param.py::_get_interp_da on handling with some params now without ping_time dim * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove isel(ping_time=0) for beam_type split_beam_angle.py::get_angle_complex_samples * revise comments and fix typo --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1057 by removing
ping_timedimension artificially added to some variables inset_groups_*.The PR also adds comments on sections of test functions where explicit
ping_timedim drop is required.