Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant ping_time dimension #1057

Closed
leewujung opened this issue Jun 6, 2023 · 1 comment
Closed

Remove redundant ping_time dimension #1057

leewujung opened this issue Jun 6, 2023 · 1 comment
Assignees
Labels
data format Anything about data format
Milestone

Comments

@leewujung
Copy link
Member

Similar to #978, the convention requires the beam dimension for many variables, but for the echosounder models we support many of these variables do not change over ping_time during a deployment or survey, since they are properties of the transducers. This dimension was artificially created in the current code.

Since ping_time is a major dimension that data is being concatenated on, this repetition is costly when data is loaded into memory (though it compresses well). I think we should consider removing this redundant dimension.

@emiliom : tagging you so that it goes with work in #1056.

@leewujung leewujung mentioned this issue Jun 6, 2023
6 tasks
@emiliom emiliom added the data format Anything about data format label Jul 11, 2023
@emiliom emiliom added this to the 0.8.0 milestone Jul 11, 2023
@emiliom emiliom assigned leewujung and unassigned emiliom Jul 20, 2023
@leewujung
Copy link
Member Author

Addressed in #1083.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data format Anything about data format
Projects
Status: Done
Development

No branches or pull requests

2 participants