Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beam dimension in EK80 angle-related calibration parameters #978

Closed
emiliom opened this issue Mar 13, 2023 · 5 comments
Closed

Remove beam dimension in EK80 angle-related calibration parameters #978

emiliom opened this issue Mar 13, 2023 · 5 comments
Assignees
Labels
data format Anything about data format
Milestone

Comments

@emiliom
Copy link
Collaborator

emiliom commented Mar 13, 2023

This is a a subset of #684 that would be very helpful to address in milestone 0.7.0.

EK80 has >1 length in the beam dimension, but these beams are actually within the same transducer (channel). This extra beam dimension added to ensure compliance to the convention is adding confusion to the code and likely runtime memory needs.

See below for calibration parameters for EK80:

"EK80": (
"sa_correction",
"gain_correction",
"equivalent_beam_angle",
"angle_offset_alongship",
"angle_offset_athwartship",
"angle_sensitivity_alongship",
"angle_sensitivity_athwartship",
"beamwidth_alongship",
"beamwidth_athwartship",
"impedance_transmit", # z_et
"impedance_receive", # z_er
"receiver_sampling_frequency",
),

Note that these stored values in the Beam_groupX or Vendor-specific group (if exist, some may not) are transducer-specific and therefore do not vary with beam or ping_time.

@emiliom emiliom added this to the 0.7.0 milestone Mar 13, 2023
@emiliom emiliom self-assigned this Mar 13, 2023
@leewujung leewujung changed the title beam dimension in EK80 calibrated data Remove beam dimension in EK80 angle-related calibration parameters Mar 17, 2023
@leewujung
Copy link
Member

@emiliom : I've updated the description above. Let me know if you have questions.

@emiliom emiliom modified the milestones: 0.7.0, 0.7.1 Mar 24, 2023
@emiliom emiliom added the data format Anything about data format label Apr 14, 2023
@emiliom
Copy link
Collaborator Author

emiliom commented May 12, 2023

EK80 has >1 length in the beam dimension, but these beams are actually within the same transducer (channel).

Note that these stored values in the Beam_groupX or Vendor-specific group (if exist, some may not) are transducer-specific and therefore do not vary with beam or ping_time.

@leewujung I'm trying to see if I understand. You're saying there are multiple beams within each transducer (channel), but the values of the variables you've listed are constant across beam (and ping_time), within each channel, right?

Do other EK80 variables that currently have a beam dimension vary across the beam dimension? The main such variables are backscatter_r and backscatter_i, but these also occur:

beam_direction_x
beam_direction_y
beam_direction_z
angle_alongship
angle_athwartship
frequency_start
frequency_end

@emiliom emiliom modified the milestones: 0.7.1, 0.7.2 May 17, 2023
@emiliom
Copy link
Collaborator Author

emiliom commented May 23, 2023

For reference: the addition of the beam dimension was originally discussed in #520

@leewujung
Copy link
Member

@leewujung I'm trying to see if I understand. You're saying there are multiple beams within each transducer (channel), but the values of the variables you've listed are constant across beam (and ping_time), within each channel, right?

Yes, they are constant across beam and ping_time, within each channel.

Do other EK80 variables that currently have a beam dimension vary across the beam dimension? The main such variables are backscatter_r and backscatter_i, but these also occur:

beam_direction_x
beam_direction_y
beam_direction_z
angle_alongship
angle_athwartship
frequency_start
frequency_end

For EK80 complex samples (both backscatter_r and backscatter_i exist):

  • the beam dimension is necessary and valid -- they are the transducer sectors/quadrants or the "subbeam" dimension in ver.2 definition.
  • angle_alongship and angle_athwartship do not exist in the raw data -- they need to be computed using add_splitbeam_angle (right now we have that to add to Sv datasets)
  • frequency_start and frequency_end can vary across ping_time, but there is no beam dimension
  • beam_direction_x/y/z does not have beam dimension and do not vary across ping_time (for the rigid installation for most echosounders anyway)

For EK80 power/angle samples (only backscatter_r exists)

  • the data is equivalent with EK60 format, so the beam dimension is redundant
  • angle_alongship and angle_athwartship exist in the raw data with the same dimensions as backscatter_r
  • frequency_start and frequency_end do not exist -- since the data is narrowband
  • beam_direction_x/y/z does not have beam dimension and do not vary across ping_time (for the rigid installation for most echosounders anyway)

@leewujung leewujung self-assigned this Jul 22, 2023
@leewujung
Copy link
Member

Addressed in #1056.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data format Anything about data format
Projects
Status: Done
Development

No branches or pull requests

2 participants