-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove beam
dimension in EK80 angle-related calibration parameters
#978
Comments
beam
dimension in EK80 angle-related calibration parameters
@emiliom : I've updated the description above. Let me know if you have questions. |
@leewujung I'm trying to see if I understand. You're saying there are multiple beams within each transducer (channel), but the values of the variables you've listed are constant across beam (and ping_time), within each channel, right? Do other EK80 variables that currently have a
|
For reference: the addition of the |
Yes, they are constant across beam and ping_time, within each channel.
For EK80 complex samples (both
For EK80 power/angle samples (only
|
Addressed in #1056. |
This is a a subset of #684 that would be very helpful to address in milestone 0.7.0.
EK80 has >1 length in the
beam
dimension, but these beams are actually within the same transducer (channel). This extrabeam
dimension added to ensure compliance to the convention is adding confusion to the code and likely runtime memory needs.See below for calibration parameters for EK80:
echopype/echopype/calibrate/cal_params.py
Lines 18 to 31 in f8082ca
Note that these stored values in the Beam_groupX or Vendor-specific group (if exist, some may not) are transducer-specific and therefore do not vary with
beam
orping_time
.The text was updated successfully, but these errors were encountered: