Separate accounts by cluster #895
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonLeary42
force-pushed
the
separate-accounts-by-cluster
branch
2 times, most recently
from
7b1a3b3 to
90825cc
Compare
johrstrom
reviewed
Oct 17, 2025
Comment on lines
15
to
16
| # The cluster this account is associated with. | ||
| attr_reader :cluster |
Contributor
There was a problem hiding this comment.
I believe we should still embed cluster here in the information object. It seems to me like it's just a convenience thing depending on how you query and loop through clusters.
In any case, I don't think the extra information is detrimental even if it's duplicate or already known.
Contributor
|
Just let me know if you have time to continue this or if you need me to pick it up. |
Contributor
Author
|
I'll rebase and fix the merge conflicts, but I don't have time for much else. |
simonLeary42
force-pushed
the
separate-accounts-by-cluster
branch
from
90825cc to
c966fb0
Compare
Contributor
Author
|
Broke PR, linked to new one. Cherry-picked 90825cc onto |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #894.
This branch is rebased off of #890, so
"remove queue from AccountInfo"should be ignored. Here is the actual diff when comparing against the right branch. Marked as draft until 890 is merged so this can be rebased again to master.