Skip to content

Commit c966fb0

Browse files
authored
remove qos attribute from QueueInfo (#892)
1 parent f3ae303 commit c966fb0

File tree

3 files changed

+0
-8
lines changed

3 files changed

+0
-8
lines changed

lib/ood_core/job/adapters/slurm.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,6 @@ def str_to_queue_info(line)
430430
end.to_h.symbolize_keys
431431

432432
hsh[:name] = hsh[:PartitionName]
433-
hsh[:qos] = hsh[:QoS].to_s == 'N/A' ? [] : hsh[:QoS].to_s.split(',')
434433
hsh[:allow_accounts] = if hsh[:AllowAccounts].nil? || hsh[:AllowAccounts].to_s == 'ALL'
435434
nil
436435
else

lib/ood_core/job/queue_info.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ class OodCore::Job::QueueInfo
99
attr_reader :name
1010
alias to_s name
1111

12-
# The QoSes associated with this queue
13-
attr_reader :qos
14-
1512
# The accounts that are allowed to use this queue.
1613
#
1714
# nil means ALL accounts are allowed.

spec/job/adapters/slurm_spec.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1402,13 +1402,11 @@ def job_info(opts = {})
14021402
systems_queue = queues.select { |q| q.name == 'systems' }.first
14031403
expect(systems_queue.allow_accounts).to eq(['root', 'pzs0708', 'pzs0710', 'pzs0722'])
14041404
expect(systems_queue.deny_accounts).to eq([])
1405-
expect(systems_queue.qos).to eq([])
14061405
expect(systems_queue.gpu?).to eq(true)
14071406

14081407
quick_queue = queues.select { |q| q.name == 'quick' }.first
14091408
expect(quick_queue.allow_accounts).to eq(nil)
14101409
expect(quick_queue.deny_accounts).to eq(quick_deny_accounts)
1411-
expect(quick_queue.qos).to eq(['quick'])
14121410
expect(quick_queue.gpu?).to eq(false)
14131411

14141412
gpu_queue = queues.select { |q| q.name == 'gpuserial' }.first
@@ -1442,12 +1440,10 @@ def job_info(opts = {})
14421440
systems_queue = queues.select { |q| q.name == 'systems' }.first
14431441
expect(systems_queue.allow_accounts).to eq(['ROOT', 'PZS0708', 'PZS0710', 'PZS0722'])
14441442
expect(systems_queue.deny_accounts).to eq([])
1445-
expect(systems_queue.qos).to eq([])
14461443

14471444
quick_queue = queues.select { |q| q.name == 'quick' }.first
14481445
expect(quick_queue.allow_accounts).to eq(nil)
14491446
expect(quick_queue.deny_accounts).to eq(quick_deny_accounts)
1450-
expect(quick_queue.qos).to eq(['quick'])
14511447
end
14521448
end
14531449
end

0 commit comments

Comments
 (0)