Skip to content

XmlDecoder/XmlParser: throw BadDecodingError for empty/non-element enumerated arrays - #3677

Merged
marcschier merged 17 commits into
masterfrom
copilot/fix-xml-decoder-peek-exception
Apr 20, 2026
Merged

marcschier merged 17 commits into
masterfrom
copilot/fix-xml-decoder-peek-exception

Fix ReadEnumeratedThrowsWhenInvalid regression assertion

9fe1661
Select commit
Loading
Failed to load commit list.
Azure Pipelines / OPCFoundation.UA-.NETStandard succeeded Apr 20, 2026 in 6m 38s

Build #1.6.59-preview+9fe1661596 had test failures

Details

Tests

  • Failed: 1 (0.00%, 0 new, 1 recurring)
  • Passed: 143,506 (97.43%)
  • Other: 3,789 (2.57%)
  • Total: 147,296

Annotations

Check failure on line 1 in Opc.Ua.Core.Tests.Security.Certificates.CertificateValidatorTest.VerifyRejectedCertsDoNotOverflowStoreAsync

See this annotation in the file changed.

@azure-pipelines azure-pipelines / OPCFoundation.UA-.NETStandard

Opc.Ua.Core.Tests.Security.Certificates.CertificateValidatorTest.VerifyRejectedCertsDoNotOverflowStoreAsync

  Assert.That(certificates, Is.Empty)
  Expected: <empty>
  But was:  < <[Subject]
  CN=UA Lime Horse Dog Lime Pineapple Strawberry Client, O=OPC Foundation, DC=bananawhitep

[Issuer]
  CN=UA Lime Horse Dog Lime Pineapple Strawberry Client, O=OPC Foundation, DC=bananawhitep

[Serial Number]
  5E54177E73C49A195216

[Not Before]
  4/19/2026 12:00:00 AM

[Not After]
  4/19/2028 12:00:00 AM

[Thumbprint]
  C3EF89204616913D89E1684A3C74A1D673F097B8
>, <[Subject]
  CN=UA Peach Rat Black Purple Pineapple Blueberry Yellow Cat Strawberry Blue Client, O=OPC Foundation, DC=yellow_catre

[Issuer]
  CN=UA Peach Rat Black Purple Pineapple Blueberry Yellow Cat Strawberry Blue Client, O=OPC Foundation, DC=yellow_catre

[Serial Number]
  40F823C144BBDC66E2F0

[Not Before]
  4/19/2026 12:00:00 AM

[Not After]
  4/19/2028 12:00:00 AM

[Thumbprint]
  89D0C2096BA1F2DD28CB54E40BA94F79CA9594F6
>, <[Subject]
  CN=UA Yellow Green Server, O=OPC Foundation, DC=dogblueberry

[Issuer]
  CN=UA Yellow Green Server, O=OPC Foundation, DC=dogblueberry

[Serial Number]
  11EE83FDC51706A91038

[Not Before]
  4/19/2026 12:00:00 AM

[Not After]
  4/19/2028 12:00:00 AM

[Thumbprint]
  9568303C5E18FD41D45409878EBE1DEF83B32154
> >
Raw output
   at Opc.Ua.Core.Tests.Security.Certificates.CertificateValidatorTest.VerifyRejectedCertsDoNotOverflowStoreAsync() in /_/Tests/Opc.Ua.Core.Tests/Security/Certificates/CertificateValidatorTest.cs:line 475
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await[TResult](TestExecutionContext context, Func`1 invoke)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(TestExecutionContext context, Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__0()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

1)    at Opc.Ua.Core.Tests.Security.Certificates.CertificateValidatorTest.VerifyRejectedCertsDoNotOverflowStoreAsync() in /_/Tests/Opc.Ua.Core.Tests/Security/Certificates/CertificateValidatorTest.cs:line 475
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)