feat(email-notifs): send emails from admin panel for testing#2253
Merged
thisislawatts merged 1 commit intoONEARMY:masterfrom Apr 27, 2023
Merged
feat(email-notifs): send emails from admin panel for testing#2253thisislawatts merged 1 commit intoONEARMY:masterfrom
thisislawatts merged 1 commit intoONEARMY:masterfrom
Conversation
2 flaky tests on run #3372 ↗︎Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| [Common] > [User Menu] > [By Authenticated] |
Output
Screenshots
|
|
map.spec.ts • 1 flaky test • ci-chrome
| Test | Artifacts | |
|---|---|---|
| map > [By User] > should show the user a message stating their pin is rejected |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
thisislawatts
approved these changes
Apr 27, 2023
Merged
Collaborator
|
🎉 This PR is included in version 1.49.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Description
this PR creates a button in the admin notifications page that will trigger the create email function to run. this will enable email testing in the development environment.
to do this, i created another firebase function
emailNotifications-sendOncethat triggers thecreateEmailfunction through an HTTP call. it requires that the caller be an authorized user with admin permissions.we can see emails getting populated in the emails collection locally, but our local emulator env is not integrated with the email extension, so we can't test the full flow until it is deployed.
Git Issues
Closes #
Screenshots/Videos
demo-smaller.mov
to try locally follow setup here #2027
If useful, provide screenshot or capture to highlight main changes
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.