Skip to content

feat(email-notifs): send emails from admin panel for testing#2253

Merged
thisislawatts merged 1 commit intoONEARMY:masterfrom
evakill:evakill/notifications-button
Apr 27, 2023
Merged

feat(email-notifs): send emails from admin panel for testing#2253
thisislawatts merged 1 commit intoONEARMY:masterfrom
evakill:evakill/notifications-button

Conversation

@evakill
Copy link
Copy Markdown
Contributor

@evakill evakill commented Apr 27, 2023

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

this PR creates a button in the admin notifications page that will trigger the create email function to run. this will enable email testing in the development environment.

to do this, i created another firebase function emailNotifications-sendOnce that triggers the createEmail function through an HTTP call. it requires that the caller be an authorized user with admin permissions.

we can see emails getting populated in the emails collection locally, but our local emulator env is not integrated with the email extension, so we can't test the full flow until it is deployed.

Git Issues

Closes #

Screenshots/Videos

demo-smaller.mov

to try locally follow setup here #2027

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@evakill evakill requested a review from a team as a code owner April 27, 2023 06:14
@cypress
Copy link
Copy Markdown

cypress bot commented Apr 27, 2023

2 flaky tests on run #3372 ↗︎

0 82 0 0 Flakiness 2

Details:

feat(email-notifs): send emails from admin panel for testing
Project: onearmy-community-platform Commit: 9c98986fbc
Status: Passed Duration: 03:54 💡
Started: Apr 27, 2023 6:22 AM Ended: Apr 27, 2023 6:26 AM
Flakiness  common.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Common] > [User Menu] > [By Authenticated] Output Screenshots
Flakiness  map.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
map > [By User] > should show the user a message stating their pin is rejected Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@thisislawatts thisislawatts merged commit 4ecaa57 into ONEARMY:master Apr 27, 2023
@cypress cypress bot mentioned this pull request Apr 27, 2023
@onearmy-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.49.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants