feat(platform): add color toggle to follow button on research page#2251
Merged
thisislawatts merged 9 commits intoONEARMY:masterfrom Apr 27, 2023
Merged
feat(platform): add color toggle to follow button on research page#2251thisislawatts merged 9 commits intoONEARMY:masterfrom
thisislawatts merged 9 commits intoONEARMY:masterfrom
Conversation
AlfonsoGhislieri
force-pushed
the
noHara
branch
from
0aa9a95 to
0db1945
Compare
5 tasks
AlfonsoGhislieri
force-pushed
the
noHara
branch
from
0db1945 to
bda55ab
Compare
Passing run #3370 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
davehakkens
added
the
Review allow-preview ✅
Contributor
|
Visit the preview URL for this PR (updated for commit a2787aa): https://onearmy-next--pr2251-nohara-niq022pq.web.app (expires Sat, 27 May 2023 13:37:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59 |
AlfonsoGhislieri
force-pushed
the
noHara
branch
from
d278e83 to
e438d7d
Compare
AlfonsoGhislieri
force-pushed
the
noHara
branch
from
e438d7d to
136dea0
Compare
thisislawatts
approved these changes
Apr 27, 2023
Merged
Collaborator
|
🎉 This PR is included in version 1.49.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Description
This PR address some of the issues in the PR raised by @NoHara42 in #2205 and fixes the failing unit tests. Credit really goes to @NoHara42, this is just make some minor changes and adds some more thorough testing that makes sure the color is also changing!
Git Issues
Closes #2200 Closes #2205
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.