Skip to content

fix: docs deploy action#2104

Merged
chrismclarke merged 10 commits intomasterfrom
fix/docs-deploy-action
Feb 19, 2023
Merged

fix: docs deploy action#2104
chrismclarke merged 10 commits intomasterfrom
fix/docs-deploy-action

Conversation

@chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Feb 18, 2023

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Follow-up to #2099, additional code required to fix the process of deploying our documentation site.

Specifically

  • Update github action that deploys documentation to also use node 18 (follows fix: docs node 18 support #2099)
  • fix issue with config changes (baseUrl and URL format)
  • remove a few root-level files realised not included in current docs

Review Notes

The docs have already been deployed from this branch as part of dbb3d8e, so no further checks required (just see if circle-ci builds start working again post-merge)

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@cypress
Copy link

cypress bot commented Feb 18, 2023

Passing run #2942 ↗︎

0 53 0 0 Flakiness 0

Details:

chore: fix edit url
Project: onearmy-community-platform Commit: 187f59d0e0
Status: Passed Duration: 02:44 💡
Started: Feb 18, 2023 10:58 PM Ended: Feb 18, 2023 11:01 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@chrismclarke chrismclarke marked this pull request as ready for review February 18, 2023 22:45
@chrismclarke chrismclarke requested a review from a team as a code owner February 18, 2023 22:45
@chrismclarke chrismclarke merged commit d8682f7 into master Feb 19, 2023
@chrismclarke chrismclarke deleted the fix/docs-deploy-action branch February 19, 2023 17:40
@cypress cypress bot mentioned this pull request Feb 19, 2023
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.38.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants