Skip to content

fix: docs node 18 support#2099

Merged
chrismclarke merged 7 commits intomasterfrom
fix/documentation-build
Feb 18, 2023
Merged

fix: docs node 18 support#2099
chrismclarke merged 7 commits intomasterfrom
fix/documentation-build

Conversation

@chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Feb 18, 2023

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

As part of PR #2067 most workspaces were upgraded to support node 18 and webpack 5. The documentation workspace did not inherit those changes due to the way dependencies for documentation had been excluded from the main installer (included an additional yarn.lock). This PR updates the documentation workspace to work with node 18 and webpack 5, and no longer be excluded from main install.

Review Notes

Just to check that docs run and deploy. Will automatically be triggered as part of github actions post merge

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@chrismclarke chrismclarke requested a review from a team as a code owner February 18, 2023 02:07
@chrismclarke chrismclarke marked this pull request as draft February 18, 2023 07:31
@chrismclarke
Copy link
Member Author

chrismclarke commented Feb 18, 2023

Facing annoying knock-in issue where running workspace commands attempts to use webpack from the root workspace. I'm guessing the docs webpack was being hoisted to root and used for functions build, but now not picking from own workspace.

Can recreate locally at least with a clean install, so will try to fix here before merging
better logs available by cd in functions dir and running

clear; node --trace-deprecation ./node_modules/webpack/bin/webpack.js --mode=development --config webpack.dev.js

Cleanest workaround I can find is manually specifying the bin path for the functions weback command as per e62e5fd.
Not super clean but also could be worse, so if it works on CI I think should be good to go. Also needed to add ts-loader which was missing from the repo (and linked to the issue above https://github.com/TypeStrong/ts-loader/issues/1126)

@cypress
Copy link

cypress bot commented Feb 18, 2023

1 flaky tests on run #2936 ↗︎

0 53 0 0 Flakiness 1

Details:

fix: functions webpack bin
Project: onearmy-community-platform Commit: e62e5fd48b
Status: Passed Duration: 07:47 💡
Started: Feb 18, 2023 9:20 PM Ended: Feb 18, 2023 9:28 PM
Flakiness  src/integration/common.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test
[Common] > [User Menu] > [By Authenticated] Screenshot

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@chrismclarke chrismclarke marked this pull request as ready for review February 18, 2023 21:34
@chrismclarke chrismclarke merged commit 05169a5 into master Feb 18, 2023
@chrismclarke chrismclarke deleted the fix/documentation-build branch February 18, 2023 21:37
@cypress cypress bot mentioned this pull request Feb 18, 2023
@chrismclarke chrismclarke mentioned this pull request Feb 18, 2023
5 tasks
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.38.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants