Conversation
|
Facing annoying knock-in issue where running workspace commands attempts to use webpack from the root workspace. I'm guessing the docs webpack was being hoisted to root and used for functions build, but now not picking from own workspace. Can recreate locally at least with a clean install, so will try to fix here before merging Cleanest workaround I can find is manually specifying the bin path for the functions weback command as per e62e5fd. |
1 flaky tests on run #2936 ↗︎Details:
|
|||||||||||||||||||||
| Test | ||
|---|---|---|
| [Common] > [User Menu] > [By Authenticated] |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
🎉 This PR is included in version 1.38.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Checklist
PR Type
Description
As part of PR #2067 most workspaces were upgraded to support node 18 and webpack 5. The documentation workspace did not inherit those changes due to the way dependencies for documentation had been excluded from the main installer (included an additional
yarn.lock). This PR updates the documentation workspace to work with node 18 and webpack 5, and no longer be excluded from main install.Review Notes
Just to check that docs run and deploy. Will automatically be triggered as part of github actions post merge
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.