Skip to content

fix: user notifications aggregation seed #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davehakkens merged 2 commits into from
Feb 18, 2023
Merged

fix: user notifications aggregation seed #2097

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c822b1
fix: user notifications aggregation seed
chrismclarke Feb 18, 2023
a90ff65
Merge branch 'master' into fix/user-notifications-aggregation-seed
chrismclarke Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions functions/src/aggregations/userNotifications.aggregations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ interface INotificationAggregation extends IAggregation {
sourceFields: (keyof IUserDB)[]
}

const aggregations: INotificationAggregation[] = [
const UserNotificationAggregation: INotificationAggregation =
// When a user's list of notifications changes reflect to aggregation
{
sourceCollection: 'users',
Expand All @@ -19,7 +19,9 @@ const aggregations: INotificationAggregation[] = [
const user: IUserDB = dbChange.after.data() as any
const { _id, _authID, notification_settings, notifications } = user
const emailFrequency = notification_settings?.emailFrequency || null
const pending = notifications.filter((n) => !n.notified && !n.read)
const pending = (notifications || []).filter(
(n) => !n.notified && !n.read,
)
// remove user from list if they do not have emails enabled or no pending notifications
if (!emailFrequency || pending.length === 0) {
return {
Expand All @@ -31,12 +33,11 @@ const aggregations: INotificationAggregation[] = [
[_id]: { _authID, emailFrequency, notifications: pending },
}
},
},
]
}

/** Watch changes to all user docs and apply aggregations */
exports.default = functions.firestore
.document(`${DB_ENDPOINTS.users}/{id}`)
.onUpdate((change) => {
return handleDBAggregations(change, aggregations)
return handleDBAggregations(change, [UserNotificationAggregation])
})