fix: user notifications aggregation seed#2097
Merged
davehakkens merged 2 commits intomasterfrom Feb 18, 2023
Merged
Conversation
chrismclarke
requested review from
davehakkens
and removed request for
davehakkens
2 flaky tests on run #2925 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | ||
|---|---|---|
| [Notifications] > [are generated by clicking on useful for how-tos] |
Screenshot
|
|
profile.spec.ts • 1 flaky test • ci-chrome
| Test | ||
|---|---|---|
| [Profile] > [By Anonymous] > [Can view public profile] |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
chrismclarke
requested review from
davehakkens
and removed request for
a team
davehakkens
approved these changes
Feb 18, 2023
Merged
Collaborator
|
🎉 This PR is included in version 1.38.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Description
Fix minor bug blocking user notifications seed on production
Review notes
Should test if aggregations populated for user notifications following merge and deployment to dev/production.
Note - this will require having at least 1 user subscribed to notifications and a new notification triggered for initial seeding.
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.