Skip to content

Fix/commit lint #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrismclarke merged 3 commits into from
Jan 25, 2023
Merged

Fix/commit lint #2070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3bb4af
chore(deps): pin to skip latest release
thisislawatts Jan 8, 2023
fc9472e
fix: add commitlint exports
chrismclarke Jan 21, 2023
c765b11
Merge branch 'master' into fix/commit-lint
chrismclarke Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ jobs:
rm package.json
npm config set package-lock false
npm i @types/node @commitlint/types @commitlint/config-conventional --force
npx commitlint --from=$(git merge-base remotes/origin/${CIRCLE_BRANCH} master) --verbose
npx @commitlint/cli@17.4.2 --from=$(git merge-base remotes/origin/${CIRCLE_BRANCH} master) --verbose
lint:
docker: *docker
steps:
Expand Down
2 changes: 1 addition & 1 deletion commitlint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { UserConfig } from '@commitlint/types'
import path from 'path'

const Configuration: UserConfig = {
export const Configuration: UserConfig = {
extends: ['@commitlint/config-conventional'],
/** Add optional custom formatter */
formatter: path.resolve(__dirname, 'commitlint.format.ts'),
Expand Down
2 changes: 1 addition & 1 deletion commitlint.format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Formatter, FormattableReport } from '@commitlint/types'

// Custom formatter for commitlint message
const formatter: Formatter = function (report, options) {
export const formatter: Formatter = function (report, options) {
const { results, valid } = report as IFormatReport
if (results && !valid) {
console.log('\nCommit needs to be formatted as conventional commit')
Expand Down