Skip to content

Fix/commit lint#2070

Merged
chrismclarke merged 3 commits intomasterfrom
fix/commit-lint
Jan 25, 2023
Merged

Fix/commit lint#2070
chrismclarke merged 3 commits intomasterfrom
fix/commit-lint

Conversation

@chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Jan 21, 2023

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Rebase from #2065
Additionally reverts changes to exports (fails to run locally)

TBC whether we still need the updates (commitlint seems to be running smoother, but probably still good to pin to a version)

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@chrismclarke chrismclarke marked this pull request as ready for review January 21, 2023 04:21
@chrismclarke chrismclarke requested a review from a team as a code owner January 21, 2023 04:21
@chrismclarke chrismclarke requested review from thisislawatts and removed request for a team January 21, 2023 04:21
@chrismclarke
Copy link
Member Author

@thisislawatts
I realised the problem when running locally was for whatever reason exporting the config as export const ... wasn't recognised so for now I've duplicated to also include a module.exports syntax.

Let me know if you think it still makes sense to keep this, if so happy to merge as-is or if there's any other additions you were planning to add

@cypress
Copy link

cypress bot commented Jan 21, 2023



Test summary

52 0 0 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit c765b11
Started Jan 21, 2023 4:21 AM
Ended Jan 21, 2023 4:25 AM
Duration 03:19 💡
OS Linux Ubuntu -
Browser Chrome 109

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@thisislawatts
Copy link
Contributor

Happy for this to merge as is, thanks for getting to the bottom of this @chrismclarke 🙏🏻

@chrismclarke chrismclarke merged commit b85c777 into master Jan 25, 2023
@chrismclarke chrismclarke deleted the fix/commit-lint branch January 25, 2023 04:02
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants