Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Did I get you in a rabbit hole here @chrismclarke 🙈 |
Haha, how could you tell! Yeah was a bit of a pain because changes to github actions only show up after the code has been pushed, and also have the added fun of writing code on windows that will run on linux with custom github environment. But all looks to be working now, so I'm going to go ahead and merge this in, release a new docker image and get on with my life |
|
🎉 This PR is included in version 1.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Checklist
PR Type
Description
It appears that recent updates in firebase have broken the emulator build. The version of firebase used should have been pinned to a specific version to avoid sudden changes, however this was not being enforced correctly when building as part of github actions (only when building locally).
This PR fixes by populating the fixed version number to a file which is passed into the the cloud build action, just as the argument is set when building locally
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.