Skip to content

Fix/docker build#2034

Merged
chrismclarke merged 18 commits intomasterfrom
fix/docker-build
Dec 14, 2022
Merged

Fix/docker build#2034
chrismclarke merged 18 commits intomasterfrom
fix/docker-build

Conversation

@chrismclarke
Copy link
Copy Markdown
Member

@chrismclarke chrismclarke commented Dec 13, 2022

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

It appears that recent updates in firebase have broken the emulator build. The version of firebase used should have been pinned to a specific version to avoid sudden changes, however this was not being enforced correctly when building as part of github actions (only when building locally).

This PR fixes by populating the fixed version number to a file which is passed into the the cloud build action, just as the argument is set when building locally

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@cypress
Copy link
Copy Markdown

cypress bot commented Dec 13, 2022



Test summary

52 0 0 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit 1fb5930
Started Dec 14, 2022 12:51 AM
Ended Dec 14, 2022 12:53 AM
Duration 02:55 💡
OS Linux Ubuntu - 20.04
Browser Chrome 108

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@davehakkens
Copy link
Copy Markdown
Contributor

Did I get you in a rabbit hole here @chrismclarke 🙈

@chrismclarke chrismclarke marked this pull request as ready for review December 14, 2022 00:42
@chrismclarke chrismclarke requested a review from a team as a code owner December 14, 2022 00:42
@chrismclarke
Copy link
Copy Markdown
Member Author

Did I get you in a rabbit hole here @chrismclarke 🙈

Haha, how could you tell! Yeah was a bit of a pain because changes to github actions only show up after the code has been pushed, and also have the added fun of writing code on windows that will run on linux with custom github environment.

But all looks to be working now, so I'm going to go ahead and merge this in, release a new docker image and get on with my life

@chrismclarke chrismclarke merged commit 5718f33 into master Dec 14, 2022
@chrismclarke chrismclarke deleted the fix/docker-build branch December 14, 2022 00:47
@onearmy-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants