Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to utils moved to core, #49 #66

Merged
merged 6 commits into from
Aug 21, 2019
Merged

Adapt to utils moved to core, #49 #66

merged 6 commits into from
Aug 21, 2019

Conversation

kba
Copy link
Member

@kba kba commented Aug 1, 2019

This is the companion PR to OCR-D/core#268

@kba kba requested review from wrznr and bertsky August 1, 2019 18:15
Copy link
Collaborator

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not run this combination yet, but it looks all good.

ocrd_tesserocr/common.py Outdated Show resolved Hide resolved
@bertsky

This comment has been minimized.

@kba
Copy link
Member Author

kba commented Aug 20, 2019

Really? (I thought that seeing those FIXMEs in the report one by one is a major reason for running pylint?)

Was an oversight, just disabled to concentrate on code changes, will fix.

Could you delete the file altogether (to avoid confusion in the future)?

Which file do you mean? pylintrc?

@bertsky
Copy link
Collaborator

bertsky commented Aug 20, 2019

Could you delete the file altogether (to avoid confusion in the future)?

Which file do you mean? pylintrc?

No, common.py

Copy link
Contributor

@wrznr wrznr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #66 into master will decrease coverage by 2.13%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   50.24%   48.11%   -2.14%     
==========================================
  Files           9        8       -1     
  Lines         828      688     -140     
  Branches      149      130      -19     
==========================================
- Hits          416      331      -85     
+ Misses        370      325      -45     
+ Partials       42       32      -10
Impacted Files Coverage Δ
ocrd_tesserocr/binarize.py 22.72% <0%> (-1.16%) ⬇️
ocrd_tesserocr/crop.py 15.53% <0%> (-0.82%) ⬇️
ocrd_tesserocr/deskew.py 17.77% <0%> (-0.91%) ⬇️
ocrd_tesserocr/segment_word.py 81.13% <100%> (-0.35%) ⬇️
ocrd_tesserocr/segment_line.py 80.39% <100%> (-0.38%) ⬇️
ocrd_tesserocr/segment_region.py 73.1% <33.33%> (-0.23%) ⬇️
ocrd_tesserocr/recognize.py 53.5% <80%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca2530d...0cdc020. Read the comment docs.

@kba kba changed the title [WIP] adapt to utils moved to core, #49 Adapt to utils moved to core, #49 Aug 21, 2019
@kba kba merged commit d1b1296 into OCR-D:master Aug 21, 2019
@kba kba deleted the core-common branch August 21, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants