Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use common functionalities from "ocrd-utils" #49

Closed
wrznr opened this issue Jul 3, 2019 · 4 comments
Closed

Use common functionalities from "ocrd-utils" #49

wrznr opened this issue Jul 3, 2019 · 4 comments
Assignees
@bertsky
Labels
cleanup Keep the code nice and smooth

Comments

@wrznr
Copy link
Contributor

wrznr commented Jul 3, 2019

As soon as they are available, the common functionalities from core should be employed.
@wrznr wrznr added the cleanup Keep the code nice and smooth label Jul 3, 2019
@bertsky
Copy link
Collaborator

bertsky commented Jul 3, 2019

Right, we should move common into core, but the image functions all depend on the workspace instance, so I think ocrd.workspace.Workspace would be the best place for them. (The coordinate conversion functions should of course go to ocrd_utils.)

@kba
Copy link
Member

kba commented Jul 9, 2019

Most of the ocrd_* modules have their own utils modules that are too specific for ocrd_utils.

For the image_from_* functions, it would indeed make most sense to have them in workspace as you proposed.

@bertsky
Copy link
Collaborator

bertsky commented Jul 9, 2019

Splendid. Just note, I will add a PR in ocrd_tesserocr which will rebase everything in common on true polygons (and masking instead of cropping). We should wait for that version in core.

This was referenced Aug 1, 2019
Merged
Merged
kba added a commit to kba/ocrd_tesserocr that referenced this issue Aug 1, 2019
@kba
adapt to utils moved to core, OCR-D#49
c17341e
kba added a commit that referenced this issue Aug 21, 2019
@kba
Merge pull request #66 from kba/core-common
d1b1296 
Adapt to utils moved to core, #49
@kba
Copy link
Member

kba commented Aug 24, 2019

Has been implemented as of #66

@kba kba closed this as completed Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertsky bertsky

Labels
cleanup Keep the code nice and smooth
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kba @wrznr @bertsky